From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3EE2C433F5 for ; Mon, 21 Feb 2022 10:00:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AD24010EF5A; Mon, 21 Feb 2022 10:00:42 +0000 (UTC) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by gabe.freedesktop.org (Postfix) with ESMTPS id 93F1810E30E for ; Mon, 21 Feb 2022 10:00:12 +0000 (UTC) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id F1B26580263; Mon, 21 Feb 2022 05:00:11 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 21 Feb 2022 05:00:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; bh=wo7FPeVWcNwQpaAIKec1keSAY7TMIw rBbsYQO8S+w+A=; b=B8FgR3sCJLWpKMtN0zAS+wpJW16KR5RFXlIZF13uiyprbG gktvFBUgER6uhSV32IFptkArPlQQGCeZroHs7DWpZQwFp9b61ekxXY3AzvtXA/Vt S3qh50NfX0SagN+EoSrAnN8YLbphrkPalYQco8MTtojaUf8WAFLVLMBLTIvRnCQJ rZq6Evn3U1wj6oalunOXcnTFX2EeMVxNSdRDy2hkQxY9HW9zs/f4QwmEsV8BeEPZ uLEOoyaPuq06XQAEzISMNLlTbejilOFPc/i6faWnF5Vcu+jrd0Vz4y/O2SmZezH6 6/ww7ra47rlQJRewPuh2yEpljX813gIgTC/tEB9w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=wo7FPe VWcNwQpaAIKec1keSAY7TMIwrBbsYQO8S+w+A=; b=CsnfciTxo0Le1GCB7XPs9d yX2Fs0vYWJc0yDjpcF4w76mbNUUydjqWmOgLRlqDTxBWNFOUaqPsbWPsWRQtZTGv 5Utm6Bs/mdtC+3rQMkfxGJnMrXlARNUSoIMJCbI8IRM16FaZ2v248/ZXwkTnXzJi gU+8on1nCMEtR82FLrBjooHLE1KJI3psrQQ2owIyFtIF5y+cbuFcf5RbNiD9AFNQ vLRQ8wriKgELvaxpQrDnoTMJAXYG43WkkH4JMdexkusgQS93b8VRZ1sHSoJmhxqh 2K+56acy5rfomJE8c2n5Sfx0hERsMaInI/sCvDpTZnzWFwAnd2zeyLNxV9P3YEaQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkeeigddtlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpedvkeelveefffekjefhffeuleetleefudeifeehuddugffghffhffehveevheeh vdenucevlhhushhtvghrufhiiigvpeefnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg igihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 21 Feb 2022 05:00:10 -0500 (EST) From: Maxime Ripard To: Daniel Vetter , David Airlie Subject: [PATCH v2 21/22] drm/imx: ipuv3-plane: Remove redundant color encoding and range initialisation Date: Mon, 21 Feb 2022 10:59:17 +0100 Message-Id: <20220221095918.18763-22-maxime@cerno.tech> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220221095918.18763-1-maxime@cerno.tech> References: <20220221095918.18763-1-maxime@cerno.tech> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pengutronix Kernel Team , Dom Cobley , Tim Gover , Dave Stevenson , Shawn Guo , Sascha Hauer , dri-devel@lists.freedesktop.org, Maxime Ripard , Thomas Zimmermann , Phil Elwell , linux-arm-kernel@lists.infradead.org, NXP Linux Team Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The imx KMS driver will call drm_plane_create_color_properties() with a default encoding and range values of BT601 and Limited Range, respectively. Since the initial value wasn't carried over in the state, the driver had to set it again in ipu_plane_state_reset(). However, the helpers have been adjusted to set it properly at reset, so this is not needed anymore. Cc: linux-arm-kernel@lists.infradead.org Cc: NXP Linux Team Cc: Fabio Estevam Cc: Pengutronix Kernel Team Cc: Philipp Zabel Cc: Sascha Hauer Cc: Shawn Guo Signed-off-by: Maxime Ripard --- drivers/gpu/drm/imx/ipuv3-plane.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c index 414bdf08d0b0..36b32e8806e3 100644 --- a/drivers/gpu/drm/imx/ipuv3-plane.c +++ b/drivers/gpu/drm/imx/ipuv3-plane.c @@ -308,11 +308,8 @@ static void ipu_plane_state_reset(struct drm_plane *plane) ipu_state = kzalloc(sizeof(*ipu_state), GFP_KERNEL); - if (ipu_state) { + if (ipu_state) __drm_atomic_helper_plane_reset(plane, &ipu_state->base); - ipu_state->base.color_encoding = DRM_COLOR_YCBCR_BT601; - ipu_state->base.color_range = DRM_COLOR_YCBCR_LIMITED_RANGE; - } } static struct drm_plane_state * -- 2.35.1