From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91F1FC433EF for ; Wed, 2 Mar 2022 08:54:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E0DCD10EE74; Wed, 2 Mar 2022 08:54:44 +0000 (UTC) X-Greylist: delayed 589 seconds by postgrey-1.36 at gabe; Wed, 02 Mar 2022 07:40:12 UTC Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) by gabe.freedesktop.org (Postfix) with ESMTPS id D888F10EF26 for ; Wed, 2 Mar 2022 07:40:12 +0000 (UTC) Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id B8E6F1C0B81; Wed, 2 Mar 2022 08:30:18 +0100 (CET) Date: Wed, 2 Mar 2022 08:30:16 +0100 From: Pavel Machek To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH 5/5] spi: make remove callback a void function Message-ID: <20220302073016.GB32222@amd> References: <20220123175201.34839-1-u.kleine-koenig@pengutronix.de> <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xXmbgvnjoT4axfJE" Content-Disposition: inline In-Reply-To: <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> User-Agent: Mutt/1.5.23 (2014-03-12) X-Mailman-Approved-At: Wed, 02 Mar 2022 08:54:41 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Gwendal Grignou , Yasunari Takiguchi , Claudius Heine , Geert Uytterhoeven , Nanyong Sun , dri-devel@lists.freedesktop.org, Jaroslav Kysela , Frieder Schrempf , Miquel Raynal , Christian Lamparter , Ajay Singh , linux-clk@vger.kernel.org, Stefan Schmidt , Sidong Yang , libertas-dev@lists.infradead.org, linux-omap@vger.kernel.org, Guenter Roeck , Jean Delvare , linux-serial@vger.kernel.org, =?utf-8?Q?=C5=81ukasz?= Stelmach , Mark Tomlinson , James Schulman , Kamlesh Gurudasani , Jingoo Han , Zhang Qilong , Randy Dunlap , linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Michael Walle , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , kernel@pengutronix.de, Greg Kroah-Hartman , linux-mtd@lists.infradead.org, Andrew Morton , Vladimir Oltean , linux-wpan@vger.kernel.org, Claudiu Beznea , Alexandre Belloni , Dan Robertson , Markuss Broks , Lucas Tanure , David Airlie , linux-wireless@vger.kernel.org, Marco Felsch , David Rhodes , Thierry Reding , Solomon Peachy , Marek =?iso-8859-1?Q?Beh=FAn?= , Krzysztof Kozlowski , Emmanuel Gil Peyrot , Jiri Slaby , Bartosz Golaszewski , Tudor Ambarus , Minghao Chi , Jon Hunter , dingsenjie , Heiko Schocher , Wolfgang Grandegger , Matt Kline , Woojung Huh , Charles Keepax , Michael Hennerich , Mike Looijmans , Ronald =?iso-8859-1?Q?Tschal=E4r?= , Daniel Thompson , linux-can@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Hans de Goede , Stephen Boyd , Davidlohr Bueso , UNGLinuxDriver@microchip.com, Jarkko Sakkinen , linux-usb@vger.kernel.org, Maxime Coquelin , linux-integrity@vger.kernel.org, Jonathan Cameron , Heiner Kallweit , Ulf Hansson , linux-staging@lists.linux.dev, linux-iio@vger.kernel.org, Michael Turquette , alsa-devel@alsa-project.org, Nuno =?iso-8859-1?Q?S=E1?= , netdev@vger.kernel.org, Wei Yongjun , Sam Ravnborg , =?iso-8859-1?B?Suly9G1l?= Pouiller , linux-rtc@vger.kernel.org, Marcus Folkesson , Florian Fainelli , Aditya Srivastava , Varka Bhadram , wengjianfeng , linux-input@vger.kernel.org, linux-media@vger.kernel.org, Arnd Bergmann , Jonathan =?iso-8859-1?Q?Neusch=E4fer?= , Mark Greer , Mark Gross , Richard Fitzgerald , Mark Brown , linux-fbdev@vger.kernel.org, Mauro Carvalho Chehab , Stefan =?iso-8859-1?Q?M=E4tje?= , linux-hwmon@vger.kernel.org, Felipe Balbi , Paulo Miguel Almeida , Support Opensource , Dmitry Torokhov , linux-mmc@vger.kernel.org, Liam Girdwood , Julia Lawall , Yang Li , Dan Carpenter , patches@opensource.cirrus.com, Kent Gustavsson , "David S. Miller" , Charles-Antoine Couret , Alexander Aring , Jiri Prchal , Vignesh Raghavendra , Emma Anholt , Peter Zijlstra , Alexandre Torgue , Alexandru Ardelean , Antoniu Miclaus , Peter Huewe , Torin Cooper-Bennun , Lee Jones , linux-leds@vger.kernel.org, Eric Piel , Stephan Gerhold , Richard Weinberger , Russell King , Jason Gunthorpe , Thomas Kopp , Jakub Kicinski , Vivien Didelot , platform-driver-x86@vger.kernel.org, Stefan Wahren , Xue Liu , David Lechner , Will Deacon , Manivannan Sadhasivam , Kalle Valo , Rui Miguel Silva , Marc Kleine-Budde , Harry Morris , Andy Shevchenko , Vincent Mailhol , Alessandro Zummo , Yang Shen , Thomas Zimmermann , Takashi Iwai , Cai Huoqing , Daniel Mack , Colin Ian King , Helge Deller , Alan Ott Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --xXmbgvnjoT4axfJE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > The value returned by an spi driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) >=20 > So change the prototype of the remove function to return no value. This > way driver authors are not tempted to assume that passing an error to > the upper layer is a good idea. All drivers are adapted accordingly. > There is no intended change of behaviour, all callbacks were prepared to > return 0 before. Acked-by: Pavel Machek Pavel --=20 http://www.livejournal.com/~pavelmachek --xXmbgvnjoT4axfJE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmIfHQgACgkQMOfwapXb+vLxcgCghFIMSLkgbmU4bCcL4+4sOBXY b1QAoKETSRxn6hbtUUF5RsaX43sun2ct =6C0C -----END PGP SIGNATURE----- --xXmbgvnjoT4axfJE--