From: Jason Gunthorpe <jgg@nvidia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
intel-gvt-dev@lists.freedesktop.org,
Zhi Wang <zhi.a.wang@intel.com>
Subject: Re: [PATCH 06/34] drm/i915/gvt: move the gvt code into kvmgt.ko
Date: Mon, 11 Apr 2022 15:43:08 -0300 [thread overview]
Message-ID: <20220411184308.GF2120790@nvidia.com> (raw)
In-Reply-To: <20220411141403.86980-7-hch@lst.de>
On Mon, Apr 11, 2022 at 04:13:35PM +0200, Christoph Hellwig wrote:
> Instead of having an option to build the gvt code into the main i915
> module, just move it into the kvmgt.ko module. This only requires
> a new struct with three entries that the KVMGT modules needs to register
> with the main i915 module, and a proper list of GVT-enabled devices
> instead of global device pointer.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/gpu/drm/i915/Kconfig | 36 ++--
> drivers/gpu/drm/i915/Makefile | 2 +-
> drivers/gpu/drm/i915/gvt/Makefile | 5 +-
> drivers/gpu/drm/i915/gvt/gvt.c | 55 ++----
> drivers/gpu/drm/i915/gvt/gvt.h | 6 +-
> drivers/gpu/drm/i915/gvt/kvmgt.c | 14 +-
> drivers/gpu/drm/i915/gvt/mpt.h | 3 -
> drivers/gpu/drm/i915/i915_driver.c | 7 -
> drivers/gpu/drm/i915/i915_drv.h | 1 +
> drivers/gpu/drm/i915/intel_gvt.c | 200 +++++++++++++-------
> drivers/gpu/drm/i915/intel_gvt.h | 17 +-
> drivers/gpu/drm/i915/intel_gvt_mmio_table.c | 1 +
> 12 files changed, 193 insertions(+), 154 deletions(-)
There is a few things going on in here, I looked a few times and
didn't spot anything..
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
next prev parent reply other threads:[~2022-04-11 18:43 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220411141403.86980-1-hch@lst.de>
[not found] ` <20220411141403.86980-3-hch@lst.de>
2022-04-11 15:23 ` [PATCH 02/34] drm/i915/gvt: remove enum hypervisor_type Jason Gunthorpe
[not found] ` <20220411141403.86980-4-hch@lst.de>
2022-04-11 15:23 ` [PATCH 03/34] drm/i915/gvt: rename intel_vgpu_ops to intel_vgpu_mdev_ops Jason Gunthorpe
[not found] ` <20220411141403.86980-5-hch@lst.de>
2022-04-11 15:24 ` [PATCH 04/34] drm/i915/gvt: don't override the include path Jason Gunthorpe
2022-04-11 16:09 ` Jani Nikula
[not found] ` <20220411141403.86980-6-hch@lst.de>
2022-04-11 15:25 ` [PATCH 05/34] drm/i915/gvt: cleanup the Makefile Jason Gunthorpe
2022-04-11 16:11 ` Jani Nikula
[not found] ` <20220411165121.GA26801@lst.de>
2022-04-13 12:33 ` Jani Nikula
2022-04-13 13:39 ` Wang, Zhi A
2022-04-13 13:43 ` Jason Gunthorpe
2022-04-13 14:26 ` Wang, Zhi A
2022-04-13 14:45 ` Jason Gunthorpe
2022-04-21 6:40 ` Joonas Lahtinen
[not found] ` <20220411141403.86980-8-hch@lst.de>
2022-04-11 15:32 ` [PATCH 07/34] drm/i915/gvt: remove intel_gvt_ops Jason Gunthorpe
[not found] ` <20220411141403.86980-9-hch@lst.de>
2022-04-11 16:00 ` [PATCH 08/34] drm/i915/gvt: remove the map_gfn_to_mfn and set_trap_area ops Jason Gunthorpe
[not found] ` <20220411141403.86980-10-hch@lst.de>
2022-04-11 16:00 ` [PATCH 09/34] drm/i915/gvt: remove the unused from_virt_to_mfn op Jason Gunthorpe
[not found] ` <20220411141403.86980-11-hch@lst.de>
2022-04-11 16:12 ` [PATCH 10/34] drm/i915/gvt: merge struct kvmgt_vdev into struct intel_vgpu Jason Gunthorpe
[not found] ` <20220411141403.86980-12-hch@lst.de>
2022-04-11 16:13 ` [PATCH 11/34] drm/i915/gvt: merge struct kvmgt_guest_info into strut intel_vgpu Jason Gunthorpe
[not found] ` <20220411141403.86980-13-hch@lst.de>
2022-04-11 16:14 ` [PATCH 12/34] drm/i915/gvt: remove vgpu->handle Jason Gunthorpe
[not found] ` <20220411141403.86980-14-hch@lst.de>
2022-04-11 16:15 ` [PATCH 13/34] drm/i915/gvt: devirtualize ->{read,write}_gpa Jason Gunthorpe
[not found] ` <20220411141403.86980-15-hch@lst.de>
2022-04-11 16:26 ` [PATCH 14/34] drm/i915/gvt: devirtualize ->{get,put}_vfio_device Jason Gunthorpe
[not found] ` <20220411141403.86980-16-hch@lst.de>
2022-04-11 16:27 ` [PATCH 15/34] drm/i915/gvt: devirtualize ->set_edid and ->set_opregion Jason Gunthorpe
[not found] ` <20220411141403.86980-17-hch@lst.de>
2022-04-11 16:27 ` [PATCH 16/34] drm/i915/gvt: devirtualize ->detach_vgpu Jason Gunthorpe
[not found] ` <20220411141403.86980-18-hch@lst.de>
2022-04-11 16:28 ` [PATCH 17/34] drm/i915/gvt: devirtualize ->inject_msi Jason Gunthorpe
[not found] ` <20220411141403.86980-19-hch@lst.de>
2022-04-11 16:29 ` [PATCH 18/34] drm/i915/gvt: devirtualize ->is_valid_gfn Jason Gunthorpe
[not found] ` <20220411141403.86980-20-hch@lst.de>
2022-04-11 16:29 ` [PATCH 19/34] drm/i915/gvt: devirtualize ->gfn_to_mfn Jason Gunthorpe
[not found] ` <20220411141403.86980-21-hch@lst.de>
2022-04-11 16:31 ` [PATCH 20/34] drm/i915/gvt: devirtualize ->{enable,disable}_page_track Jason Gunthorpe
[not found] ` <20220411141403.86980-22-hch@lst.de>
2022-04-11 18:08 ` [PATCH 21/34] drm/i915/gvt: devirtualize ->dma_{,un}map_guest_page Jason Gunthorpe
[not found] ` <20220411141403.86980-23-hch@lst.de>
2022-04-11 18:09 ` [PATCH 22/34] drm/i915/gvt: devirtualize dma_pin_guest_page Jason Gunthorpe
[not found] ` <20220411141403.86980-24-hch@lst.de>
2022-04-11 18:13 ` [PATCH 23/34] drm/i915/gvt: remove struct intel_gvt_mpt Jason Gunthorpe
[not found] ` <20220411141403.86980-25-hch@lst.de>
2022-04-11 18:33 ` [PATCH 24/34] drm/i915/gvt: remove the extra vfio_device refcounting for dmabufs Jason Gunthorpe
[not found] ` <20220411141403.86980-29-hch@lst.de>
2022-04-11 18:36 ` [PATCH 28/34] drm/i915/gvt: convert to use vfio_register_emulated_iommu_dev Jason Gunthorpe
[not found] ` <20220411141403.86980-26-hch@lst.de>
2022-04-11 18:37 ` [PATCH 25/34] drm/i915/gvt: streamline intel_vgpu_create Jason Gunthorpe
[not found] ` <20220411141403.86980-27-hch@lst.de>
2022-04-11 18:38 ` [PATCH 26/34] drm/i915/gvt: pass a struct intel_vgpu to the vfio read/write helpers Jason Gunthorpe
[not found] ` <20220411141403.86980-28-hch@lst.de>
2022-04-11 18:41 ` [PATCH 27/34] drm/i915/gvt: remove kvmgt_guest_{init,exit} Jason Gunthorpe
[not found] ` <20220411141403.86980-30-hch@lst.de>
2022-04-11 18:42 ` [PATCH 29/34] drm/i915/gvt: merge gvt.c into kvmgvt.c Jason Gunthorpe
[not found] ` <20220411141403.86980-7-hch@lst.de>
2022-04-11 18:43 ` Jason Gunthorpe [this message]
[not found] ` <20220411141403.86980-31-hch@lst.de>
2022-04-12 20:51 ` [PATCH 30/34] vfio/mdev: Remove vfio_mdev.c Kirti Wankhede
[not found] ` <20220411141403.86980-32-hch@lst.de>
2022-04-12 20:51 ` [PATCH 31/34] vfio/mdev: Remove mdev_parent_ops dev_attr_groups Kirti Wankhede
[not found] ` <20220411141403.86980-33-hch@lst.de>
2022-04-12 20:51 ` [PATCH 32/34] vfio/mdev: Remove mdev_parent_ops Kirti Wankhede
[not found] ` <20220411141403.86980-34-hch@lst.de>
2022-04-12 20:52 ` [PATCH 33/34] vfio/mdev: Use the driver core to create the 'remove' file Kirti Wankhede
[not found] ` <20220411141403.86980-35-hch@lst.de>
2022-04-12 20:52 ` [PATCH 34/34] vfio/mdev: Remove mdev drvdata Kirti Wankhede
2022-04-13 13:47 ` refactor the i915 GVT support and move to the modern mdev API v3 Wang, Zhi A
[not found] ` <20220413154642.GA28095@lst.de>
2022-04-13 15:58 ` Jani Nikula
2022-04-13 23:13 ` Wang, Zhi A
2022-04-13 23:20 ` Jason Gunthorpe
2022-04-14 12:20 ` Wang, Zhi A
2022-04-14 13:34 ` Jason Gunthorpe
2022-04-14 13:39 ` Wang, Zhi A
2022-04-14 13:41 ` Jason Gunthorpe
2022-04-14 13:44 ` Jani Nikula
2022-04-14 13:40 ` Jani Nikula
2022-04-14 13:43 ` Jason Gunthorpe
2022-04-14 14:25 ` Wang, Zhi A
2022-04-14 14:38 ` Jason Gunthorpe
[not found] ` <20220420070800.GB4417@lst.de>
2022-04-20 7:12 ` Wang, Zhi A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220411184308.GF2120790@nvidia.com \
--to=jgg@nvidia.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=zhi.a.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox