dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nancy.Lin <nancy.lin@mediatek.com>
To: Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	<wim@linux-watchdog.org>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>, <linux@roeck-us.net>
Cc: devicetree@vger.kernel.org,
	Project_Global_Chrome_Upstream_Group@mediatek.com,
	Yongqiang Niu <yongqiang.niu@mediatek.com>,
	srv_heupstream@mediatek.com, David Airlie <airlied@linux.ie>,
	"jason-jh . lin" <jason-jh.lin@mediatek.com>,
	singo.chang@mediatek.com, llvm@lists.linux.dev,
	Nick Desaulniers <ndesaulniers@google.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Nathan Chancellor <nathan@kernel.org>,
	"Nancy . Lin" <nancy.lin@mediatek.com>,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v17 07/21] soc: mediatek: mmsys: modify reset controller for MT8195 vdosys1
Date: Sat, 16 Apr 2022 10:07:35 +0800	[thread overview]
Message-ID: <20220416020749.29010-8-nancy.lin@mediatek.com> (raw)
In-Reply-To: <20220416020749.29010-1-nancy.lin@mediatek.com>

MT8195 vdosys1 has more than 32 reset bits and a different reset base
than other chips. Modify mmsys for support 64 bit and different reset
base.

Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 drivers/soc/mediatek/mt8195-mmsys.h |  1 +
 drivers/soc/mediatek/mtk-mmsys.c    | 39 ++++++++++++++++++-----------
 drivers/soc/mediatek/mtk-mmsys.h    |  1 +
 3 files changed, 27 insertions(+), 14 deletions(-)

diff --git a/drivers/soc/mediatek/mt8195-mmsys.h b/drivers/soc/mediatek/mt8195-mmsys.h
index 5469073e3073..0a286fa5a824 100644
--- a/drivers/soc/mediatek/mt8195-mmsys.h
+++ b/drivers/soc/mediatek/mt8195-mmsys.h
@@ -139,6 +139,7 @@
 #define MT8195_VDO1_MIXER_SOUT_SEL_IN				0xf68
 #define MT8195_MIXER_SOUT_SEL_IN_FROM_DISP_MIXER			0
 
+#define MT8195_VDO1_SW0_RST_B		0x1d0
 #define MT8195_VDO1_MERGE0_ASYNC_CFG_WD	0xe30
 #define MT8195_VDO1_HDRBE_ASYNC_CFG_WD	0xe70
 #define MT8195_VDO1_HDR_TOP_CFG		0xd00
diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
index ea04aa2c3840..d7c806f9e494 100644
--- a/drivers/soc/mediatek/mtk-mmsys.c
+++ b/drivers/soc/mediatek/mtk-mmsys.c
@@ -20,6 +20,8 @@
 #include "mt8195-mmsys.h"
 #include "mt8365-mmsys.h"
 
+#define MMSYS_SW_RESET_PER_REG 32
+
 static const struct mtk_mmsys_driver_data mt2701_mmsys_driver_data = {
 	.clk_driver = "clk-mt2701-mm",
 	.routes = mmsys_default_routing_table,
@@ -86,6 +88,7 @@ static const struct mtk_mmsys_driver_data mt8173_mmsys_driver_data = {
 	.routes = mmsys_default_routing_table,
 	.num_routes = ARRAY_SIZE(mmsys_default_routing_table),
 	.sw0_rst_offset = MT8183_MMSYS_SW0_RST_B,
+	.num_resets = 32,
 };
 
 static const struct mtk_mmsys_match_data mt8173_mmsys_match_data = {
@@ -100,6 +103,7 @@ static const struct mtk_mmsys_driver_data mt8183_mmsys_driver_data = {
 	.routes = mmsys_mt8183_routing_table,
 	.num_routes = ARRAY_SIZE(mmsys_mt8183_routing_table),
 	.sw0_rst_offset = MT8183_MMSYS_SW0_RST_B,
+	.num_resets = 32,
 };
 
 static const struct mtk_mmsys_match_data mt8183_mmsys_match_data = {
@@ -114,6 +118,7 @@ static const struct mtk_mmsys_driver_data mt8186_mmsys_driver_data = {
 	.routes = mmsys_mt8186_routing_table,
 	.num_routes = ARRAY_SIZE(mmsys_mt8186_routing_table),
 	.sw0_rst_offset = MT8186_MMSYS_SW0_RST_B,
+	.num_resets = 32,
 };
 
 static const struct mtk_mmsys_match_data mt8186_mmsys_match_data = {
@@ -148,6 +153,8 @@ static const struct mtk_mmsys_driver_data mt8195_vdosys1_driver_data = {
 	.clk_driver = "clk-mt8195-vdo1",
 	.routes = mmsys_mt8195_routing_table,
 	.num_routes = ARRAY_SIZE(mmsys_mt8195_routing_table),
+	.sw0_rst_offset = MT8195_VDO1_SW0_RST_B,
+	.num_resets = 64,
 };
 
 static const struct mtk_mmsys_match_data mt8195_mmsys_match_data = {
@@ -234,18 +241,22 @@ static int mtk_mmsys_reset_update(struct reset_controller_dev *rcdev, unsigned l
 {
 	struct mtk_mmsys *mmsys = container_of(rcdev, struct mtk_mmsys, rcdev);
 	unsigned long flags;
+	u32 offset;
 	u32 reg;
 
+	offset = (id / MMSYS_SW_RESET_PER_REG) * sizeof(u32);
+	id = id % MMSYS_SW_RESET_PER_REG;
+
 	spin_lock_irqsave(&mmsys->lock, flags);
 
-	reg = readl_relaxed(mmsys->regs + mmsys->data->sw0_rst_offset);
+	reg = readl_relaxed(mmsys->regs + mmsys->data->sw0_rst_offset + offset);
 
 	if (assert)
 		reg &= ~BIT(id);
 	else
 		reg |= BIT(id);
 
-	writel_relaxed(reg, mmsys->regs + mmsys->data->sw0_rst_offset);
+	writel_relaxed(reg, mmsys->regs + mmsys->data->sw0_rst_offset + offset);
 
 	spin_unlock_irqrestore(&mmsys->lock, flags);
 
@@ -360,18 +371,6 @@ static int mtk_mmsys_probe(struct platform_device *pdev)
 		return ret;
 	}
 
-	spin_lock_init(&mmsys->lock);
-
-	mmsys->rcdev.owner = THIS_MODULE;
-	mmsys->rcdev.nr_resets = 32;
-	mmsys->rcdev.ops = &mtk_mmsys_reset_ops;
-	mmsys->rcdev.of_node = pdev->dev.of_node;
-	ret = devm_reset_controller_register(&pdev->dev, &mmsys->rcdev);
-	if (ret) {
-		dev_err(&pdev->dev, "Couldn't register mmsys reset controller: %d\n", ret);
-		return ret;
-	}
-
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	if (!res) {
 		dev_err(dev, "Couldn't get mmsys resource\n");
@@ -393,6 +392,18 @@ static int mtk_mmsys_probe(struct platform_device *pdev)
 		mmsys->data = match_data->drv_data[0];
 	}
 
+	spin_lock_init(&mmsys->lock);
+
+	mmsys->rcdev.owner = THIS_MODULE;
+	mmsys->rcdev.nr_resets = mmsys->data->num_resets;
+	mmsys->rcdev.ops = &mtk_mmsys_reset_ops;
+	mmsys->rcdev.of_node = pdev->dev.of_node;
+	ret = devm_reset_controller_register(&pdev->dev, &mmsys->rcdev);
+	if (ret) {
+		dev_err(&pdev->dev, "Couldn't register mmsys reset controller: %d\n", ret);
+		return ret;
+	}
+
 #if IS_REACHABLE(CONFIG_MTK_CMDQ)
 	ret = cmdq_dev_get_client_reg(dev, &mmsys->cmdq_base, 0);
 	if (ret)
diff --git a/drivers/soc/mediatek/mtk-mmsys.h b/drivers/soc/mediatek/mtk-mmsys.h
index 21cf300ba864..cbbffaf344c6 100644
--- a/drivers/soc/mediatek/mtk-mmsys.h
+++ b/drivers/soc/mediatek/mtk-mmsys.h
@@ -92,6 +92,7 @@ struct mtk_mmsys_driver_data {
 	const struct mtk_mmsys_routes *routes;
 	const unsigned int num_routes;
 	const u16 sw0_rst_offset;
+	const u32 num_resets;
 };
 
 struct mtk_mmsys_match_data {
-- 
2.18.0


  parent reply	other threads:[~2022-04-16  2:08 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-16  2:07 [PATCH v17 00/21] Add MediaTek SoC DRM (vdosys1) support for mt8195 Nancy.Lin
2022-04-16  2:07 ` [PATCH v17 01/21] dt-bindings: mediatek: add vdosys1 RDMA definition " Nancy.Lin
2022-04-16  2:07 ` [PATCH v17 02/21] dt-bindings: reset: mt8195: add vdosys1 reset control bit Nancy.Lin
2022-04-16  2:07 ` [PATCH v17 03/21] dt-bindings: mediatek: add ethdr definition for mt8195 Nancy.Lin
2022-04-25  9:54   ` Philipp Zabel
2022-04-28  2:25     ` Nancy.Lin
2022-04-16  2:07 ` [PATCH v17 04/21] soc: mediatek: add mtk-mmsys support for mt8195 vdosys1 Nancy.Lin
2022-04-16  2:07 ` [PATCH v17 05/21] soc: mediatek: add mtk-mmsys config API " Nancy.Lin
2022-04-21  1:53   ` Rex-BC Chen
2022-04-16  2:07 ` [PATCH v17 06/21] soc: mediatek: add cmdq support of " Nancy.Lin
2022-04-21  1:55   ` Rex-BC Chen
2022-04-22 11:37   ` Matthias Brugger
2022-04-27  7:22     ` Nancy.Lin
2022-04-16  2:07 ` Nancy.Lin [this message]
2022-04-21  1:56   ` [PATCH v17 07/21] soc: mediatek: mmsys: modify reset controller for MT8195 vdosys1 Rex-BC Chen
2022-04-22 11:37   ` Matthias Brugger
2022-04-26  8:56     ` Nancy.Lin
2022-04-16  2:07 ` [PATCH v17 08/21] soc: mediatek: add mtk-mutex support for mt8195 vdosys1 Nancy.Lin
2022-04-21  1:58   ` Rex-BC Chen
2022-04-16  2:07 ` [PATCH v17 09/21] drm/mediatek: add display MDP RDMA support for MT8195 Nancy.Lin
2022-04-16  2:07 ` [PATCH v17 10/21] drm/mediatek: add display merge advance config API " Nancy.Lin
2022-04-16  2:07 ` [PATCH v17 11/21] drm/mediatek: add display merge start/stop API for cmdq support Nancy.Lin
2022-04-22 11:48   ` Matthias Brugger
2022-04-25 13:32     ` Chun-Kuang Hu
2022-04-25 15:27       ` Matthias Brugger
2022-04-16  2:07 ` [PATCH v17 12/21] drm/mediatek: add display merge mute/unmute support for MT8195 Nancy.Lin
2022-04-16  2:07 ` [PATCH v17 13/21] drm/mediatek: add display merge async reset control Nancy.Lin
2022-04-25  9:58   ` Philipp Zabel
2022-04-26 10:28     ` Nancy.Lin
2022-04-16  2:07 ` [PATCH v17 14/21] drm/mediatek: add ETHDR support for MT8195 Nancy.Lin
2022-04-25 10:00   ` Philipp Zabel
2022-04-26 10:57     ` Nancy.Lin
2022-04-16  2:07 ` [PATCH v17 15/21] drm/mediatek: add mediatek-drm plane color encoding info Nancy.Lin
2022-04-16  2:07 ` [PATCH v17 16/21] drm/mediatek: add ovl_adaptor support for MT8195 Nancy.Lin
2022-04-16  2:07 ` [PATCH v17 17/21] drm/mediatek: add dma dev get function Nancy.Lin
2022-04-16  2:07 ` [PATCH v17 18/21] drm/mediatek: modify mediatek-drm for mt8195 multi mmsys support Nancy.Lin
2022-04-16  2:07 ` [PATCH v17 19/21] drm/mediatek: add drm ovl_adaptor sub driver for MT8195 Nancy.Lin
2022-04-16  2:07 ` [PATCH v17 20/21] drm/mediatek: add mediatek-drm of vdosys1 support " Nancy.Lin
2022-04-16  2:07 ` [PATCH v17 21/21] arm64: dts: mt8195: add display node for vdosys1 Nancy.Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220416020749.29010-8-nancy.lin@mediatek.com \
    --to=nancy.lin@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=airlied@linux.ie \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jason-jh.lin@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux@roeck-us.net \
    --cc=llvm@lists.linux.dev \
    --cc=matthias.bgg@gmail.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=singo.chang@mediatek.com \
    --cc=srv_heupstream@mediatek.com \
    --cc=wim@linux-watchdog.org \
    --cc=yongqiang.niu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox