From: Thomas Zimmermann <tzimmermann@suse.de>
To: jfalempe@redhat.com, sam@ravnborg.org, airlied@redhat.com,
airlied@linux.ie, daniel@ffwll.ch
Cc: Thomas Zimmermann <tzimmermann@suse.de>, dri-devel@lists.freedesktop.org
Subject: [PATCH v3 00/14] drm/mgag200: Move model-specific code into separate functions
Date: Thu, 28 Jul 2022 14:40:49 +0200 [thread overview]
Message-ID: <20220728124103.30159-1-tzimmermann@suse.de> (raw)
Mgag200 still mixes model-specific code and generic code in the same
functions. Separate it into distinct helpers.
As part of this effort, convert the driver from simple-KMS helpers
to regular atomic helpers. The latter are way more flexible and can
be adapted easily for each hardware model.
Tested on Matrox G200 and G200EH hardware.
v3:
* only flip SCROFF when enabling/disable the plane (Jocelyn)
* style clean-ups throughout the patchset
v2:
* don't duplicate DAC init values unecessarily (Sam, Jocelyn)
Thomas Zimmermann (14):
drm/mgag200: Split mgag200_modeset_init()
drm/mgag200: Move DAC-register setup into model-specific code
dmr/mgag200: Move ER/EW3 register initialization to per-model code
drm/mgag200: Acquire I/O-register lock in atomic_commit_tail function
drm/mgag200: Store primary plane's color format in CRTC state
drm/mgag200: Reorganize before dropping simple-KMS helpers
drm/mgag200: Replace simple-KMS with regular atomic helpers
drm/mgag200: Set SCROFF in primary-plane code
drm/mgag200: Add per-device callbacks
drm/mgag200: Provide per-device callbacks for BMC synchronization
drm/mgag200: Provide per-device callbacks for PIXPLLC
drm/mgag200: Move mode-config to model-specific code
drm/mgag200: Move CRTC atomic_enable to model-specific code
drm/mgag200: Remove type field from struct mga_device
drivers/gpu/drm/mgag200/Makefile | 4 +-
drivers/gpu/drm/mgag200/mgag200_bmc.c | 99 +++
drivers/gpu/drm/mgag200/mgag200_drv.c | 21 +-
drivers/gpu/drm/mgag200/mgag200_drv.h | 208 ++++-
drivers/gpu/drm/mgag200/mgag200_g200.c | 254 +++++-
drivers/gpu/drm/mgag200/mgag200_g200eh.c | 277 +++++-
drivers/gpu/drm/mgag200/mgag200_g200eh3.c | 181 +++-
drivers/gpu/drm/mgag200/mgag200_g200er.c | 315 ++++++-
drivers/gpu/drm/mgag200/mgag200_g200ev.c | 316 ++++++-
drivers/gpu/drm/mgag200/mgag200_g200ew3.c | 192 ++++-
drivers/gpu/drm/mgag200/mgag200_g200se.c | 431 +++++++++-
drivers/gpu/drm/mgag200/mgag200_g200wb.c | 326 ++++++-
drivers/gpu/drm/mgag200/mgag200_mode.c | 725 +++++-----------
drivers/gpu/drm/mgag200/mgag200_pll.c | 997 ----------------------
14 files changed, 2761 insertions(+), 1585 deletions(-)
create mode 100644 drivers/gpu/drm/mgag200/mgag200_bmc.c
delete mode 100644 drivers/gpu/drm/mgag200/mgag200_pll.c
base-commit: 15fbed4f822211fbb7653c2b8591594d92de9551
--
2.37.1
next reply other threads:[~2022-07-28 12:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 12:40 Thomas Zimmermann [this message]
2022-07-28 12:40 ` [PATCH v3 01/14] drm/mgag200: Split mgag200_modeset_init() Thomas Zimmermann
2022-07-28 12:40 ` [PATCH v3 02/14] drm/mgag200: Move DAC-register setup into model-specific code Thomas Zimmermann
2022-07-28 12:40 ` [PATCH v3 03/14] dmr/mgag200: Move ER/EW3 register initialization to per-model code Thomas Zimmermann
2022-07-28 12:40 ` [PATCH v3 04/14] drm/mgag200: Acquire I/O-register lock in atomic_commit_tail function Thomas Zimmermann
2022-07-28 12:40 ` [PATCH v3 05/14] drm/mgag200: Store primary plane's color format in CRTC state Thomas Zimmermann
2022-07-28 12:40 ` [PATCH v3 06/14] drm/mgag200: Reorganize before dropping simple-KMS helpers Thomas Zimmermann
2022-07-28 12:40 ` [PATCH v3 07/14] drm/mgag200: Replace simple-KMS with regular atomic helpers Thomas Zimmermann
2022-07-28 15:09 ` Jocelyn Falempe
2022-07-28 18:31 ` Thomas Zimmermann
2022-07-29 7:48 ` Jocelyn Falempe
2022-07-28 12:40 ` [PATCH v3 08/14] drm/mgag200: Set SCROFF in primary-plane code Thomas Zimmermann
2022-07-28 12:40 ` [PATCH v3 09/14] drm/mgag200: Add per-device callbacks Thomas Zimmermann
2022-07-28 12:40 ` [PATCH v3 10/14] drm/mgag200: Provide per-device callbacks for BMC synchronization Thomas Zimmermann
2022-07-28 12:41 ` [PATCH v3 11/14] drm/mgag200: Provide per-device callbacks for PIXPLLC Thomas Zimmermann
2022-07-28 12:41 ` [PATCH v3 12/14] drm/mgag200: Move mode-config to model-specific code Thomas Zimmermann
2022-07-28 12:41 ` [PATCH v3 13/14] drm/mgag200: Move CRTC atomic_enable " Thomas Zimmermann
2022-07-28 12:41 ` [PATCH v3 14/14] drm/mgag200: Remove type field from struct mga_device Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220728124103.30159-1-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jfalempe@redhat.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox