Re: [PATCH 1/2] dt-bindings: display: bridge: icn6211: Add support for RGB/BGR swap

[Rob Herring <robh@kernel.org>]

On Mon, Aug 01, 2022 at 03:19:00PM +0200, Marek Vasut wrote:
> The ICN6211 is capable of swapping the output DPI RGB/BGR color channels,
> document a DT property to select this swap in DT. This can be useful on
> hardware where such swap happens.

We should ensure this series[1] works for you instead.


> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Jagan Teki <jagan@amarulasolutions.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Robert Foss <robert.foss@linaro.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: devicetree@vger.kernel.org
> ---
>  .../devicetree/bindings/display/bridge/chipone,icn6211.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml
> index 18563ebed1a96..e721dd76e6640 100644
> --- a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml
> @@ -33,6 +33,12 @@ properties:
>          Optional external clock connected to REF_CLK input.
>          The clock rate must be in 10..154 MHz range.
>  
> +  blue-and-red-swap:

'swap' assumes I know the default order and I don't. Better to make the 
property name describe the end result. ('invert' properties have the 
same issue)

> +    description:
> +      If defined, the DPI output blue and red channels are swapped,
> +      i.e. RGB becomes BGR.
> +    type: boolean
> +
>    enable-gpios:
>      description: Bridge EN pin, chip is reset when EN is low.

Rob

[1] https://lore.kernel.org/r/20220628181838.2031-3-max.oss.09@gmail.com