From: Doug Brown <doug@schmorgal.com>
To: Lucas Stach <l.stach@pengutronix.de>,
Russell King <linux+etnaviv@armlinux.org.uk>,
Christian Gmeiner <christian.gmeiner@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: Doug Brown <doug@schmorgal.com>,
etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: [PATCH 2/2] drm/etnaviv: fix power register offset on GC300
Date: Fri, 2 Sep 2022 23:05:58 -0700 [thread overview]
Message-ID: <20220903060558.55167-3-doug@schmorgal.com> (raw)
In-Reply-To: <20220903060558.55167-1-doug@schmorgal.com>
Older GC300 revisions have their power registers at an offset of 0x200
rather than 0x100.
Signed-off-by: Doug Brown <doug@schmorgal.com>
---
drivers/gpu/drm/etnaviv/etnaviv_gpu.h | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.h b/drivers/gpu/drm/etnaviv/etnaviv_gpu.h
index 85eddd492774..b375612df862 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.h
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.h
@@ -10,6 +10,8 @@
#include "etnaviv_gem.h"
#include "etnaviv_mmu.h"
#include "etnaviv_drv.h"
+#include "common.xml.h"
+#include "state_hi.xml.h"
struct etnaviv_gem_submit;
struct etnaviv_vram_mapping;
@@ -149,14 +151,24 @@ struct etnaviv_gpu {
unsigned long base_rate_shader;
};
+static inline u32 gpu_fix_reg_address(struct etnaviv_gpu *gpu, u32 reg)
+{
+ /* Power registers in GC300 < 2.0 are offset by 0x100 */
+ if (reg >= VIVS_PM_POWER_CONTROLS && reg <= VIVS_PM_PULSE_EATER &&
+ gpu->identity.model == chipModel_GC300 &&
+ gpu->identity.revision < 0x2000)
+ reg += 0x100;
+ return reg;
+}
+
static inline void gpu_write(struct etnaviv_gpu *gpu, u32 reg, u32 data)
{
- writel(data, gpu->mmio + reg);
+ writel(data, gpu->mmio + gpu_fix_reg_address(gpu, reg));
}
static inline u32 gpu_read(struct etnaviv_gpu *gpu, u32 reg)
{
- return readl(gpu->mmio + reg);
+ return readl(gpu->mmio + gpu_fix_reg_address(gpu, reg));
}
int etnaviv_gpu_get_param(struct etnaviv_gpu *gpu, u32 param, u64 *value);
--
2.25.1
next prev parent reply other threads:[~2022-09-03 6:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-03 6:05 [PATCH 0/2] drm/etnaviv: GC300 fixes Doug Brown
2022-09-03 6:05 ` [PATCH 1/2] drm/etnaviv: add missing quirks for GC300 Doug Brown
2022-09-03 11:38 ` Christian Gmeiner
2022-09-03 6:05 ` Doug Brown [this message]
2022-09-03 11:49 ` [PATCH 2/2] drm/etnaviv: fix power register offset on GC300 Christian Gmeiner
2022-09-05 21:05 ` Doug Brown
2022-09-06 8:12 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220903060558.55167-3-doug@schmorgal.com \
--to=doug@schmorgal.com \
--cc=airlied@linux.ie \
--cc=christian.gmeiner@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=etnaviv@lists.freedesktop.org \
--cc=l.stach@pengutronix.de \
--cc=linux+etnaviv@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox