From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8BB49ECAAD8 for ; Tue, 20 Sep 2022 09:03:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4EAB010E14D; Tue, 20 Sep 2022 09:03:14 +0000 (UTC) Received: from out20-97.mail.aliyun.com (out20-97.mail.aliyun.com [115.124.20.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id 792E010E49A for ; Tue, 20 Sep 2022 09:02:21 +0000 (UTC) X-Alimail-AntiSpam: AC=CONTINUE; BC=0.04440174|-1; CH=green; DM=|CONTINUE|false|; DS=CONTINUE|ham_regular_dialog|0.0127042-0.00172802-0.985568; FP=0|0|0|0|0|-1|-1|-1; HT=ay29a033018047199; MF=wangyugui@e16-tech.com; NM=1; PH=DS; RN=3; RT=3; SR=0; TI=SMTPD_---.PJzWLnl_1663664538; Received: from 192.168.2.112(mailfrom:wangyugui@e16-tech.com fp:SMTPD_---.PJzWLnl_1663664538) by smtp.aliyun-inc.com; Tue, 20 Sep 2022 17:02:18 +0800 Date: Tue, 20 Sep 2022 17:02:20 +0800 From: Wang Yugui To: Thomas Zimmermann Subject: Re: mgag200 broken on kernel-6.0-rc3 on DELL/T620 In-Reply-To: <16995c0f-c698-b1b0-0311-73882aef5f75@suse.de> References: <20220915224058.B32A.409509F4@e16-tech.com> <16995c0f-c698-b1b0-0311-73882aef5f75@suse.de> Message-Id: <20220920170219.788D.409509F4@e16-tech.com> MIME-Version: 1.0 Content-Type: text/plain; charset="GB2312" Content-Transfer-Encoding: 8bit X-Mailer: Becky! ver. 2.75.04 [en] X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jocelyn Falempe , dri-devel Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, > Hi > > Am 15.09.22 um 16:41 schrieb Wang Yugui: > > Hi, > > > >> Hi > >> > >> Am 14.09.22 um 16:58 schrieb Wang Yugui: > >> [...] > >>>> 24-bit works on my G200HE and G200 test machines. Maybe the G200ER has a bug. > >>>> > >>>> When I try 16-bit depth, the display works, but is way too dark. No fiddling with the LUT tables fixes this. It's 90s hardware, so it should support 16-bit framebuffers well, but there's no obvious bug to be seen. > >>>> > >>>> I guess, we could remove 16 and 24 bit support for now if nothing else helps. > >>> > >>> > >>> maybe better if we revert 73f54d5d9682 (drm/mgag200: Remove special case > >>> for G200SE with <2 MiB) > >> > >> Could you please test the attached patch on the 6.0-rc3 kernel? It should force the driver to a correct color format if no kernel parameters are given. > >> > > > > This patch works well. > > I have meanwhile added the patch to drm-misc-fixes. We want to add a workaround for your machine to the driver. Can you please send me the output of > > sudo dmidecode -s system-manufacturer > > and > > sudo dmidecode -s system-product-name > DELL/T630 [root@T630 ~]# dmidecode -s system-manufacturer Dell Inc. [root@T630 ~]# dmidecode -s system-product-name PowerEdge T630 DELL/T620 [root@T620 ~]# dmidecode -s system-manufacturer Dell Inc. [root@T620 ~]# dmidecode -s system-product-name PowerEdge T620 Best Regards Wang Yugui (wangyugui@e16-tech.com) 2022/09/20 > Best regards > Thomas > > > > > test case detail: > > kernel parm video is not given > > server DELL/T620 > > kernel is 6.0-rc5 > > > > Best Regards > > Wang Yugui (wangyugui@e16-tech.com) > > 2022/09/15 > > > > > >> Best regards > >> Thomas > >> > >>> > >>> because there is no test result on device G200_SE > >>> > >>> static unsigned int mgag200_preferred_depth(struct mga_device *mdev) > >>> { > >>> if (IS_G200_SE(mdev) && mdev->vram_fb_available < (2048*1024)) > >>> return 16; > >>> else > >>> return 32; > >>> } > >>> > >>> Best Regards > >>> Wang Yugui (wangyugui@e16-tech.com) > >>> 2022/09/14 > >>> > >> -- Thomas Zimmermann > >> Graphics Driver Developer > >> SUSE Software Solutions Germany GmbH > >> Maxfeldstr. 5, 90409 Nščrnberg, Germany > >> (HRB 36809, AG Nščrnberg) > >> Gesch?ftsfščhrer: Ivo Totev > > > > > -- Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Maxfeldstr. 5, 90409 Nščrnberg, Germany > (HRB 36809, AG Nščrnberg) > Gesch?ftsfščhrer: Ivo Totev