Hi Marek,

I love your patch! Yet something to improve:

[auto build test ERROR on drm-misc/drm-misc-next]
[also build test ERROR on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-tip/drm-tip linus/master v6.1-rc2 next-20221027]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Marek-Vasut/drm-lcdif-Set-and-enable-FIFO-Panic-threshold/20221027-052135
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:    https://lore.kernel.org/r/20221026212002.542375-1-marex%40denx.de
patch subject: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold
config: arm-randconfig-r004-20221026
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/a6b02f6e5bec37c467d42a457708d565bb10d939
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Marek-Vasut/drm-lcdif-Set-and-enable-FIFO-Panic-threshold/20221027-052135
        git checkout a6b02f6e5bec37c467d42a457708d565bb10d939
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/gpu/drm/mxsfb/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/swab.h:5,
                    from include/uapi/linux/byteorder/big_endian.h:14,
                    from include/linux/byteorder/big_endian.h:5,
                    from arch/arm/include/uapi/asm/byteorder.h:20,
                    from include/asm-generic/bitops/le.h:6,
                    from arch/arm/include/asm/bitops.h:269,
                    from include/linux/bitops.h:68,
                    from include/linux/kernel.h:22,
                    from include/linux/clk.h:13,
                    from drivers/gpu/drm/mxsfb/lcdif_kms.c:8:
   drivers/gpu/drm/mxsfb/lcdif_kms.c: In function 'lcdif_enable_controller':
>> drivers/gpu/drm/mxsfb/lcdif_kms.c:334:16: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
     334 |         writel(FIELD_PREP(PANIC0_THRES_LOW_MASK, 1 * PANIC0_THRES_RANGE / 3) |
         |                ^~~~~~~~~~
   include/uapi/linux/swab.h:115:54: note: in definition of macro '__swab32'
     115 | #define __swab32(x) (__u32)__builtin_bswap32((__u32)(x))
         |                                                      ^
   include/linux/byteorder/generic.h:88:21: note: in expansion of macro '__cpu_to_le32'
      88 | #define cpu_to_le32 __cpu_to_le32
         |                     ^~~~~~~~~~~~~
   arch/arm/include/asm/io.h:290:47: note: in expansion of macro 'writel_relaxed'
     290 | #define writel(v,c)             ({ __iowmb(); writel_relaxed(v,c); })
         |                                               ^~~~~~~~~~~~~~
   drivers/gpu/drm/mxsfb/lcdif_kms.c:334:9: note: in expansion of macro 'writel'
     334 |         writel(FIELD_PREP(PANIC0_THRES_LOW_MASK, 1 * PANIC0_THRES_RANGE / 3) |
         |         ^~~~~~
   cc1: some warnings being treated as errors


vim +/FIELD_PREP +334 drivers/gpu/drm/mxsfb/lcdif_kms.c

   320	
   321	static void lcdif_enable_controller(struct lcdif_drm_private *lcdif)
   322	{
   323		u32 reg;
   324	
   325		reg = readl(lcdif->base + LCDC_V8_DISP_PARA);
   326		reg |= DISP_PARA_DISP_ON;
   327		writel(reg, lcdif->base + LCDC_V8_DISP_PARA);
   328	
   329		reg = readl(lcdif->base + LCDC_V8_CTRLDESCL0_5);
   330		reg |= CTRLDESCL0_5_EN;
   331		writel(reg, lcdif->base + LCDC_V8_CTRLDESCL0_5);
   332	
   333		/* Set FIFO Panic watermarks, low 1/3, high 2/3 . */
 > 334		writel(FIELD_PREP(PANIC0_THRES_LOW_MASK, 1 * PANIC0_THRES_RANGE / 3) |
   335		       FIELD_PREP(PANIC0_THRES_HIGH_MASK, 2 * PANIC0_THRES_RANGE / 3),
   336		       lcdif->base + LCDC_V8_PANIC0_THRES);
   337	
   338		/*
   339		 * Enable FIFO Panic, this does not generate interrupt, but
   340		 * boosts NoC priority based on FIFO Panic watermarks.
   341		 */
   342		writel(INT_ENABLE_D1_PLANE_PANIC_EN,
   343		       lcdif->base + LCDC_V8_INT_ENABLE_D1);
   344	}
   345	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp