Hi Christian, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next linus/master v6.1-rc4 next-20221108] [cannot apply to drm-tip/drm-tip] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Christian-K-nig/drm-ttm-optimize-pool-allocations-a-bit/20221108-040029 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20221107195808.1873-1-christian.koenig%40amd.com patch subject: [PATCH] drm/ttm: optimize pool allocations a bit config: s390-allyesconfig compiler: s390-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/ec55cfc840243dd3cd0d0a02ce9ae54b8b474c4d git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Christian-K-nig/drm-ttm-optimize-pool-allocations-a-bit/20221108-040029 git checkout ec55cfc840243dd3cd0d0a02ce9ae54b8b474c4d # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/gpu/drm/ttm/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/gpu/drm/ttm/ttm_pool.c:348:5: warning: no previous prototype for 'ttm_pool_page_allocated' [-Wmissing-prototypes] 348 | int ttm_pool_page_allocated(struct ttm_pool *pool, unsigned int order, | ^~~~~~~~~~~~~~~~~~~~~~~ vim +/ttm_pool_page_allocated +348 drivers/gpu/drm/ttm/ttm_pool.c 346 347 /* Called when we got a page, either from a pool or newly allocated */ > 348 int ttm_pool_page_allocated(struct ttm_pool *pool, unsigned int order, 349 struct page *p, dma_addr_t **dma_addr, 350 unsigned long *num_pages, struct page ***pages) 351 { 352 unsigned int i; 353 int r; 354 355 if (*dma_addr) { 356 r = ttm_pool_map(pool, order, p, dma_addr); 357 if (r) 358 return r; 359 } 360 361 *num_pages -= 1 << order; 362 for (i = 1 << order; i; --i) 363 *((*pages)++) = p++; 364 365 return 0; 366 } 367 -- 0-DAY CI Kernel Test Service https://01.org/lkp