From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: [RFC 5/5] drm/i915: Wait boost requests waited upon by others
Date: Fri, 10 Feb 2023 13:06:47 +0000 [thread overview]
Message-ID: <20230210130647.580135-6-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <20230210130647.580135-1-tvrtko.ursulin@linux.intel.com>
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Use the newly added dma-fence API to apply waitboost not only requests
which have been marked with I915_WAIT_PRIORITY by i915, but which may be
waited upon by others (such as for instance buffer sharing in multi-GPU
scenarios).
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
drivers/gpu/drm/i915/i915_request.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
index 488b180f8821..e24fac5c1567 100644
--- a/drivers/gpu/drm/i915/i915_request.c
+++ b/drivers/gpu/drm/i915/i915_request.c
@@ -2042,7 +2042,8 @@ long i915_request_wait_timeout(struct i915_request *rq,
* but at a cost of spending more power processing the workload
* (bad for battery).
*/
- if (flags & I915_WAIT_PRIORITY && !i915_request_started(rq))
+ if (((flags & I915_WAIT_PRIORITY) || dma_fence_wait_count(&rq->fence))
+ && !i915_request_started(rq))
intel_rps_boost(rq);
wait.tsk = current;
--
2.34.1
next prev parent reply other threads:[~2023-02-10 13:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 13:06 [RFC v2 0/5] Waitboost drm syncobj waits Tvrtko Ursulin
2023-02-10 13:06 ` [RFC 1/5] dma-fence: Track explicit waiters Tvrtko Ursulin
2023-02-10 13:06 ` [RFC 2/5] drm/syncobj: Mark syncobj waits as external waiters Tvrtko Ursulin
2023-02-10 13:06 ` [RFC 3/5] drm/i915: Waitboost external waits Tvrtko Ursulin
2023-02-10 13:06 ` [RFC 4/5] drm/i915: Mark waits as explicit Tvrtko Ursulin
2023-02-10 13:06 ` Tvrtko Ursulin [this message]
2023-02-14 19:14 ` [Intel-gfx] [RFC v2 0/5] Waitboost drm syncobj waits Rob Clark
2023-02-14 19:26 ` Rob Clark
2023-02-16 11:19 ` Tvrtko Ursulin
2023-02-16 15:43 ` Rob Clark
2023-02-16 18:19 ` Rodrigo Vivi
2023-02-16 19:59 ` Rob Clark
2023-02-17 12:56 ` Tvrtko Ursulin
2023-02-17 14:55 ` Rob Clark
2023-02-17 16:03 ` Tvrtko Ursulin
2023-02-17 17:00 ` Rob Clark
2023-02-17 20:45 ` Rodrigo Vivi
2023-02-17 23:38 ` Rob Clark
2023-02-20 11:33 ` Tvrtko Ursulin
2023-02-20 15:52 ` Rob Clark
2023-02-20 16:44 ` Tvrtko Ursulin
2023-02-20 16:51 ` Tvrtko Ursulin
2023-02-20 17:14 ` Rob Clark
2023-02-20 17:07 ` Rob Clark
2023-02-20 12:22 ` Tvrtko Ursulin
2023-02-20 15:45 ` Rob Clark
2023-02-20 15:56 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230210130647.580135-6-tvrtko.ursulin@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).