dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: patrik.r.jakobsson@gmail.com, airlied@gmail.com, daniel@ffwll.ch
Cc: Thomas Zimmermann <tzimmermann@suse.de>, dri-devel@lists.freedesktop.org
Subject: [PATCH 3/7] drm/gma500: Remove fbdev vma open and close callbacks
Date: Thu, 23 Feb 2023 13:17:29 +0100	[thread overview]
Message-ID: <20230223121733.12549-4-tzimmermann@suse.de> (raw)
In-Reply-To: <20230223121733.12549-1-tzimmermann@suse.de>

Remove fbdev emulations' open and close implementaitons for the VM. The
functions are empty. Also update the naming of the VMA code.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/gma500/fbdev.c | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/gma500/fbdev.c b/drivers/gpu/drm/gma500/fbdev.c
index 9ce76b11d256..6885550f6815 100644
--- a/drivers/gpu/drm/gma500/fbdev.c
+++ b/drivers/gpu/drm/gma500/fbdev.c
@@ -18,7 +18,7 @@
  * VM area struct
  */
 
-static vm_fault_t psbfb_vm_fault(struct vm_fault *vmf)
+static vm_fault_t psb_fbdev_vm_fault(struct vm_fault *vmf)
 {
 	struct vm_area_struct *vma = vmf->vma;
 	struct drm_framebuffer *fb = vma->vm_private_data;
@@ -49,16 +49,8 @@ static vm_fault_t psbfb_vm_fault(struct vm_fault *vmf)
 	return ret;
 }
 
-static void psbfb_vm_open(struct vm_area_struct *vma)
-{ }
-
-static void psbfb_vm_close(struct vm_area_struct *vma)
-{ }
-
-static const struct vm_operations_struct psbfb_vm_ops = {
-	.fault	= psbfb_vm_fault,
-	.open	= psbfb_vm_open,
-	.close	= psbfb_vm_close
+static const struct vm_operations_struct psb_fbdev_vm_ops = {
+	.fault	= psb_fbdev_vm_fault,
 };
 
 /*
@@ -122,7 +114,7 @@ static int psbfb_mmap(struct fb_info *info, struct vm_area_struct *vma)
 	 * kernel remapping of the object. FIXME: Review if this is
 	 * suitable for our mmap work
 	 */
-	vma->vm_ops = &psbfb_vm_ops;
+	vma->vm_ops = &psb_fbdev_vm_ops;
 	vma->vm_private_data = (void *)fb;
 	vma->vm_flags |= VM_IO | VM_MIXEDMAP | VM_DONTEXPAND | VM_DONTDUMP;
 
-- 
2.39.2


  parent reply	other threads:[~2023-02-23 12:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-23 12:17 [PATCH 0/7] drm/gma500: Convert fbdev to DRM client Thomas Zimmermann
2023-02-23 12:17 ` [PATCH 1/7] drm/gma500: Remove unnecessary include statements Thomas Zimmermann
2023-02-23 12:17 ` [PATCH 2/7] drm/gma500: Move fbdev code into separate source file Thomas Zimmermann
2023-02-27  7:10   ` Patrik Jakobsson
2023-02-27  7:40     ` Thomas Zimmermann
2023-02-27  7:48       ` Patrik Jakobsson
2023-03-06 14:51   ` Patrik Jakobsson
2023-02-23 12:17 ` Thomas Zimmermann [this message]
2023-02-23 12:17 ` [PATCH 4/7] drm/gma500: Fix naming in fb_ops Thomas Zimmermann
2023-02-23 12:17 ` [PATCH 5/7] drm/gma500: Inline psbfb_create() into psbfb_probe() Thomas Zimmermann
2023-03-06 14:51   ` Patrik Jakobsson
2023-02-23 12:17 ` [PATCH 6/7] drm/gma500: Implement client-based fbdev emulation Thomas Zimmermann
2023-02-23 19:01   ` kernel test robot
2023-02-24  7:58     ` Thomas Zimmermann
2023-02-23 19:22   ` kernel test robot
2023-02-23 21:04   ` kernel test robot
2023-02-23 12:17 ` [PATCH 7/7] drm/gma500: Pass fb_info to psb_fbdev_vm_fault() Thomas Zimmermann
2023-03-06 14:52   ` Patrik Jakobsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230223121733.12549-4-tzimmermann@suse.de \
    --to=tzimmermann@suse.de \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=patrik.r.jakobsson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox