From: Thomas Zimmermann <tzimmermann@suse.de>
To: patrik.r.jakobsson@gmail.com, airlied@gmail.com, daniel@ffwll.ch
Cc: Thomas Zimmermann <tzimmermann@suse.de>, dri-devel@lists.freedesktop.org
Subject: [PATCH v2 4/7] drm/gma500: Fix naming in fb_ops
Date: Mon, 13 Mar 2023 16:16:07 +0100 [thread overview]
Message-ID: <20230313151610.14367-5-tzimmermann@suse.de> (raw)
In-Reply-To: <20230313151610.14367-1-tzimmermann@suse.de>
Fix some names around struct fb_ops to better fit the overall naming
conventions. No functional changes.
v2:
* fix typo in commit message
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/gma500/fbdev.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/gma500/fbdev.c b/drivers/gpu/drm/gma500/fbdev.c
index 8d181cb26440..f5c4c89a7c47 100644
--- a/drivers/gpu/drm/gma500/fbdev.c
+++ b/drivers/gpu/drm/gma500/fbdev.c
@@ -59,10 +59,10 @@ static const struct vm_operations_struct psb_fbdev_vm_ops = {
#define CMAP_TOHW(_val, _width) ((((_val) << (_width)) + 0x7FFF - (_val)) >> 16)
-static int psbfb_setcolreg(unsigned int regno,
- unsigned int red, unsigned int green,
- unsigned int blue, unsigned int transp,
- struct fb_info *info)
+static int psb_fbdev_fb_setcolreg(unsigned int regno,
+ unsigned int red, unsigned int green,
+ unsigned int blue, unsigned int transp,
+ struct fb_info *info)
{
struct drm_fb_helper *fb_helper = info->par;
struct drm_framebuffer *fb = fb_helper->fb;
@@ -99,7 +99,7 @@ static int psbfb_setcolreg(unsigned int regno,
return 0;
}
-static int psbfb_mmap(struct fb_info *info, struct vm_area_struct *vma)
+static int psb_fbdev_fb_mmap(struct fb_info *info, struct vm_area_struct *vma)
{
struct drm_fb_helper *fb_helper = info->par;
struct drm_framebuffer *fb = fb_helper->fb;
@@ -121,16 +121,16 @@ static int psbfb_mmap(struct fb_info *info, struct vm_area_struct *vma)
return 0;
}
-static const struct fb_ops psbfb_unaccel_ops = {
+static const struct fb_ops psb_fbdev_fb_ops = {
.owner = THIS_MODULE,
DRM_FB_HELPER_DEFAULT_OPS,
- .fb_setcolreg = psbfb_setcolreg,
+ .fb_setcolreg = psb_fbdev_fb_setcolreg,
.fb_read = drm_fb_helper_cfb_read,
.fb_write = drm_fb_helper_cfb_write,
.fb_fillrect = drm_fb_helper_cfb_fillrect,
.fb_copyarea = drm_fb_helper_cfb_copyarea,
.fb_imageblit = drm_fb_helper_cfb_imageblit,
- .fb_mmap = psbfb_mmap,
+ .fb_mmap = psb_fbdev_fb_mmap,
};
/*
@@ -190,7 +190,7 @@ static int psbfb_create(struct drm_fb_helper *fb_helper,
fb_helper->fb = fb;
- info->fbops = &psbfb_unaccel_ops;
+ info->fbops = &psb_fbdev_fb_ops;
info->fix.smem_start = dev_priv->fb_base;
info->fix.smem_len = size;
--
2.39.2
next prev parent reply other threads:[~2023-03-13 15:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 15:16 [PATCH v2 0/7] drm/gma500: Convert fbdev to DRM client Thomas Zimmermann
2023-03-13 15:16 ` [PATCH v2 1/7] drm/gma500: Remove unnecessary include statements Thomas Zimmermann
2023-03-13 15:16 ` [PATCH v2 2/7] drm/gma500: Move fbdev code into separate source file Thomas Zimmermann
2023-03-13 15:16 ` [PATCH v2 3/7] drm/gma500: Remove fbdev vma open and close callbacks Thomas Zimmermann
2023-03-13 15:16 ` Thomas Zimmermann [this message]
2023-03-13 15:16 ` [PATCH v2 5/7] drm/gma500: Inline psbfb_create() into psbfb_probe() Thomas Zimmermann
2023-03-13 15:16 ` [PATCH v2 6/7] drm/gma500: Implement client-based fbdev emulation Thomas Zimmermann
2023-03-13 15:16 ` [PATCH v2 7/7] drm/gma500: Pass fb_info to psb_fbdev_vm_fault() Thomas Zimmermann
2023-03-16 8:46 ` [PATCH v2 0/7] drm/gma500: Convert fbdev to DRM client Patrik Jakobsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230313151610.14367-5-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=patrik.r.jakobsson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox