From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0AF72C7618A for ; Sun, 19 Mar 2023 13:13:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EED8B10E162; Sun, 19 Mar 2023 13:13:01 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7A48810E162 for ; Sun, 19 Mar 2023 13:13:00 +0000 (UTC) Received: from pendragon.ideasonboard.com (85-76-162-78-nat.elisa-mobile.fi [85.76.162.78]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BBAF91858; Sun, 19 Mar 2023 14:12:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1679231578; bh=/r8ObLyvEZV8rs1xRhx4UsZVHgsYFJFhifnA3TcgfOw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ktNUMzDgkjvggrnSuYTnyZ9cXjqpq8cH6o8Ez3F9BIRmrH7LKVWZTq9Ja4vtHvYed HF2KOMdNrzPh1j+hHH8U/7Iw77PrzDxS4FOGRsHO06ymkTaZ3pEkNTOdPcch90u04h 5Lq//ctHOb9G/+FNUInep+V4M2iEu3q2HwHL5wq4= Date: Sun, 19 Mar 2023 15:13:01 +0200 From: Laurent Pinchart To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Subject: Re: [PATCH 01/19] drm/bridge: cdns-mhdp8546: Improve error reporting in remove callback Message-ID: <20230319131301.GF10144@pendragon.ideasonboard.com> References: <20230318190804.234610-1-u.kleine-koenig@pengutronix.de> <20230318190804.234610-2-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230318190804.234610-2-u.kleine-koenig@pengutronix.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Robert Foss , Andrzej Hajda , Sam Ravnborg , Jonas Karlman , Jani Nikula , Thomas Zimmermann , Javier Martinez Canillas , Jernej Skrabec , Tetsuo Handa , dri-devel@lists.freedesktop.org, Alex Deucher , kernel@pengutronix.de Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Uwe, Thank you for the patch. On Sat, Mar 18, 2023 at 08:07:46PM +0100, Uwe Kleine-König wrote: > Replace the generic error message issued by the driver core when the remove > callback returns non-zero ("remove callback returned a non-zero value. This > will be ignored.") by a message that tells the actual problem. > > Also simplify a bit by checking the return value of wait_event_timeout a > bit later. > > Signed-off-by: Uwe Kleine-König > --- > .../drm/bridge/cadence/cdns-mhdp8546-core.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c > index f6822dfa3805..d74c6fa30ccc 100644 > --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c > +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c > @@ -2574,7 +2574,6 @@ static int cdns_mhdp_remove(struct platform_device *pdev) > { > struct cdns_mhdp_device *mhdp = platform_get_drvdata(pdev); > unsigned long timeout = msecs_to_jiffies(100); > - bool stop_fw = false; > int ret; > > drm_bridge_remove(&mhdp->bridge); > @@ -2582,18 +2581,19 @@ static int cdns_mhdp_remove(struct platform_device *pdev) > ret = wait_event_timeout(mhdp->fw_load_wq, > mhdp->hw_state == MHDP_HW_READY, > timeout); > - if (ret == 0) > - dev_err(mhdp->dev, "%s: Timeout waiting for fw loading\n", > - __func__); > - else > - stop_fw = true; > - > spin_lock(&mhdp->start_lock); > mhdp->hw_state = MHDP_HW_STOPPED; > spin_unlock(&mhdp->start_lock); > > - if (stop_fw) > + if (ret == 0) { > + dev_err(mhdp->dev, "%s: Timeout waiting for fw loading\n", > + __func__); > + } else { > ret = cdns_mhdp_set_firmware_active(mhdp, false); > + if (ret) > + dev_err(mhdp->dev, "Failed to stop firmware (%pe)\n", > + ERR_PTR(ret)); Why not simply dev_err(mhdp->dev, "Failed to stop firmware (%d)\n", ret); ? Apart from that, Reviewed-by: Laurent Pinchart > + } > > phy_exit(mhdp->phy); > > @@ -2609,7 +2609,7 @@ static int cdns_mhdp_remove(struct platform_device *pdev) > > clk_disable_unprepare(mhdp->clk); > > - return ret; > + return 0; > } > > static const struct of_device_id mhdp_ids[] = { -- Regards, Laurent Pinchart