From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE493C6FD1D for ; Mon, 20 Mar 2023 08:21:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E88F710E255; Mon, 20 Mar 2023 08:21:51 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id BA7C010E255 for ; Mon, 20 Mar 2023 08:21:50 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E3660B80CAA; Mon, 20 Mar 2023 08:21:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 729FAC433D2; Mon, 20 Mar 2023 08:21:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679300507; bh=jVn18uqDt5rfFoXE/I7E0XizLiknyMconn6QPnHtdLQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TSwW0AmSxuRFtl0g9F718VJ2W3q6LSKylGHTNj9byCTSaZa6mlm/YCrmaJK5BS5j1 KGSEu3WXqYU/juOPwBpq7C1HipAEgLNnNrIoJnWvOolIeHrqU2KVXLXzrmoRcZEXCB ic9NSivyMigokjCbK3nFimEnng8NY6cvs61609sPkBvN6Fg/LW5Yh1dFrRFTTWysWm xTgXxDQZ/U2syZd8qk8wHLvc/yO6NTVHqYBl2RS31lX50Ti9WugSaWFtLH7sBjQZsY eqdFR7wvA3UbmjyV1XPTDGu3b5l2JNMcGNOETU3it5RSiMkyt0WLv0KpcPIk2ueuzf JkzKs4IFnOr8Q== Date: Mon, 20 Mar 2023 08:21:41 +0000 From: Lee Jones To: Liu Ying Subject: Re: [PATCH 37/37] drm/bridge/imx/Kconfig: Prevent imx-ldb-helper from appearing in 2 separate modules Message-ID: <20230320082141.GJ9667@google.com> References: <20230317081718.2650744-1-lee@kernel.org> <20230317081718.2650744-38-lee@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Jernej Skrabec , Robert Foss , Jonas Karlman , Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Laurent Pinchart , Andrzej Hajda , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org, NXP Linux Team Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 17 Mar 2023, Liu Ying wrote: > Hi Lee, > > On Fri, 2023-03-17 at 08:17 +0000, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > scripts/Makefile.build:252: drivers/gpu/drm/bridge/imx/Makefile: imx-ldb-helper.o is added to multiple modules: imx8qm-ldb imx8qxp-ldb > > > > Cc: Liu Ying > > Cc: Andrzej Hajda > > Cc: Neil Armstrong > > Cc: Robert Foss > > Cc: Laurent Pinchart > > Cc: Jonas Karlman > > Cc: Jernej Skrabec > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: Shawn Guo > > Cc: Sascha Hauer > > Cc: Pengutronix Kernel Team > > Cc: Fabio Estevam > > Cc: NXP Linux Team > > Cc: dri-devel@lists.freedesktop.org > > Cc: linux-arm-kernel@lists.infradead.org > > Signed-off-by: Lee Jones > > Thank you for the patch. > > > --- > > drivers/gpu/drm/bridge/imx/Kconfig | 7 +++++++ > > drivers/gpu/drm/bridge/imx/Makefile | 7 +++++-- > > drivers/gpu/drm/bridge/imx/imx-ldb-helper.c | 13 +++++++++++++ > > 3 files changed, 25 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/bridge/imx/Kconfig b/drivers/gpu/drm/bridge/imx/Kconfig > > index 608f47f41bcd1..97018dcd078d0 100644 > > --- a/drivers/gpu/drm/bridge/imx/Kconfig > > +++ b/drivers/gpu/drm/bridge/imx/Kconfig > > @@ -1,10 +1,16 @@ > > if ARCH_MXC || COMPILE_TEST > > > > +config DRM_IMX8_LIB > > I would limit this to i.MX LVDS Display Bridge(LDB) library, so I > suggest to use DRM_IMX_LDB_LIB. > > > + tristate > > + help > > + Common helper functions used by some of the drivers below. > > Considering to use DRM_IMX_LDB_LIB, help message can be a bit more > specific to LDB drivers, like: > > Common helper functions used by i.MX LVDS display bridge drivers below. Thanks for the help. Leave it with me. -- Lee Jones [李琼斯]