From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2405C6FD1C for ; Wed, 22 Mar 2023 20:01:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D52F810EA09; Wed, 22 Mar 2023 20:01:57 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2B5F610EA09 for ; Wed, 22 Mar 2023 20:01:56 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9B6E8622C1; Wed, 22 Mar 2023 20:01:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FD75C4339B; Wed, 22 Mar 2023 20:01:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679515315; bh=L0ppsVkM3L1IhzDIY/wbSoHkSWthJizIcAiKa9RNvfk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lAJeJfWFRMokNlF57/WqDZrtLS/I8wByNQ2YcoJntlOw5Maki4vSfM9t4TbA8+tUZ G8dZfA7j/c8/1KxlNbqak1AC04atqRdVzHdf9vXq3G7KEHVmBuYYAIIY4fpgZSj31q O3ed37/nKd6sYMUogOchktKPhrCigYraQPGK0gh3MYiJO9AuSZ9cJL4UnAJtYPGRMs 8SWOAw/IYvOuE0zt9+JPZqZF1u4+124Nlw1OP3dEEsaYFSFbeL3eBnlRpjlfgmJgS3 O9ZyhYRJSlWiciFu12iVycI09MH5kijGUIu10+f7YkVm2EGPJ6r8E3/fHnc+jN5SW3 TFIe/fJNw3NYA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 10/16] fbdev: nvidia: Fix potential divide by zero Date: Wed, 22 Mar 2023 16:01:14 -0400 Message-Id: <20230322200121.1997157-10-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230322200121.1997157-1-sashal@kernel.org> References: <20230322200121.1997157-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , linux-fbdev@vger.kernel.org, adaplas@gmail.com, Helge Deller , dri-devel@lists.freedesktop.org, Wei Chen Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Wei Chen [ Upstream commit 92e2a00f2987483e1f9253625828622edd442e61 ] variable var->pixclock can be set by user. In case it equals to zero, divide by zero would occur in nvidiafb_set_par. Similar crashes have happened in other fbdev drivers. There is no check and modification on var->pixclock along the call chain to nvidia_check_var and nvidiafb_set_par. We believe it could also be triggered in driver nvidia from user site. Signed-off-by: Wei Chen Signed-off-by: Helge Deller Signed-off-by: Sasha Levin --- drivers/video/fbdev/nvidia/nvidia.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/fbdev/nvidia/nvidia.c b/drivers/video/fbdev/nvidia/nvidia.c index a372a183c1f01..f9c388a8c10e3 100644 --- a/drivers/video/fbdev/nvidia/nvidia.c +++ b/drivers/video/fbdev/nvidia/nvidia.c @@ -763,6 +763,8 @@ static int nvidiafb_check_var(struct fb_var_screeninfo *var, int pitch, err = 0; NVTRACE_ENTER(); + if (!var->pixclock) + return -EINVAL; var->transp.offset = 0; var->transp.length = 0; -- 2.39.2