From: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
To: dri-devel@lists.freedesktop.org
Cc: Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>,
Oded Gabbay <ogabbay@kernel.org>,
Jeffrey Hugo <quic_jhugo@quicinc.com>,
Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>,
Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
Subject: [PATCH v2 8/8] accel/ivpu: Fix IPC buffer header status field value
Date: Thu, 23 Mar 2023 13:55:04 +0100 [thread overview]
Message-ID: <20230323125504.2586442-9-stanislaw.gruszka@linux.intel.com> (raw)
In-Reply-To: <20230323125504.2586442-1-stanislaw.gruszka@linux.intel.com>
From: Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>
IPC messages transmitted to the device must be marked as
allocated - status field must be set to 1. The VPU driver
has IVPU_IPC_HDR_ALLOCATED incorrectly defined. Future VPU
firmware versions will reject all IPC messages with invalid
status and will not work with a VPU driver that is missing
this fix.
Fixes: 5d7422cfb498 ("accel/ivpu: Add IPC driver and JSM messages")
Signed-off-by: Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>
Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
---
drivers/accel/ivpu/ivpu_ipc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accel/ivpu/ivpu_ipc.h b/drivers/accel/ivpu/ivpu_ipc.h
index 9838202ecfad..68f5b6668e00 100644
--- a/drivers/accel/ivpu/ivpu_ipc.h
+++ b/drivers/accel/ivpu/ivpu_ipc.h
@@ -21,7 +21,7 @@ struct ivpu_bo;
#define IVPU_IPC_ALIGNMENT 64
#define IVPU_IPC_HDR_FREE 0
-#define IVPU_IPC_HDR_ALLOCATED 0
+#define IVPU_IPC_HDR_ALLOCATED 1
/**
* struct ivpu_ipc_hdr - The IPC message header structure, exchanged
--
2.25.1
next prev parent reply other threads:[~2023-03-23 12:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 12:54 [PATCH v2 0/8] accel/ivpu: Fixes for 6.3 Stanislaw Gruszka
2023-03-23 12:54 ` [PATCH v2 1/8] accel/ivpu: Do not access HW registers after unbind Stanislaw Gruszka
2023-03-23 12:54 ` [PATCH v2 2/8] accel/ivpu: Cancel recovery work Stanislaw Gruszka
2023-03-23 14:59 ` Jeffrey Hugo
2023-03-23 12:54 ` [PATCH v2 3/8] accel/ivpu: Do not use SSID 1 Stanislaw Gruszka
2023-03-23 15:00 ` Jeffrey Hugo
2023-03-23 12:55 ` [PATCH v2 4/8] accel/ivpu: Fix power down sequence Stanislaw Gruszka
2023-03-23 12:55 ` [PATCH v2 5/8] accel/ivpu: Disable buttress on device removal Stanislaw Gruszka
2023-03-23 12:55 ` [PATCH v2 6/8] accel/ivpu: Remove support for 1 tile SKUs Stanislaw Gruszka
2023-03-23 12:55 ` [PATCH v2 7/8] accel/ivpu: Fix VPU clock calculation Stanislaw Gruszka
2023-03-23 15:01 ` Jeffrey Hugo
2023-03-23 12:55 ` Stanislaw Gruszka [this message]
2023-03-23 15:02 ` [PATCH v2 8/8] accel/ivpu: Fix IPC buffer header status field value Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230323125504.2586442-9-stanislaw.gruszka@linux.intel.com \
--to=stanislaw.gruszka@linux.intel.com \
--cc=andrzej.kacprowski@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.lawrynowicz@linux.intel.com \
--cc=ogabbay@kernel.org \
--cc=quic_jhugo@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox