From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16EE0C77B72 for ; Mon, 17 Apr 2023 12:38:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1F55C10E306; Mon, 17 Apr 2023 12:38:52 +0000 (UTC) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 701B810E309 for ; Mon, 17 Apr 2023 12:38:50 +0000 (UTC) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1poO88-0006IW-KR; Mon, 17 Apr 2023 14:38:48 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1poO88-0001gy-2e; Mon, 17 Apr 2023 14:38:48 +0200 Date: Mon, 17 Apr 2023 14:38:48 +0200 From: Sascha Hauer To: Heiko =?iso-8859-15?Q?St=FCbner?= Subject: Re: [PATCH] drm/rockchip: vop2: fix suspend/resume Message-ID: <20230417123848.GN15436@pengutronix.de> References: <20230417094215.2049231-1-s.hauer@pengutronix.de> <7404631.18pcnM708K@diego> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7404631.18pcnM708K@diego> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?iso-8859-15?Q?K=F6ry?= Maincent , Sandy Huang , dri-devel@lists.freedesktop.org, Chris Morgan , Paul Kocialkowski , linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, stable@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Apr 17, 2023 at 12:46:05PM +0200, Heiko Stübner wrote: > Hi Sascha, > > Am Montag, 17. April 2023, 11:42:15 CEST schrieb Sascha Hauer: > > During a suspend/resume cycle the VO power domain will be disabled and > > the VOP2 registers will reset to their default values. After that the > > cached register values will be out of sync and the read/modify/write > > operations we do on the window registers will result in bogus values > > written. Fix this by marking the regcache as dirty each time we disable > > the VOP2 and call regcache_sync() each time we enable it again. With > > this the VOP2 will show a picture after a suspend/resume cycle whereas > > without this the screen stays dark. > > > > Fixes: 604be85547ce4 ("drm/rockchip: Add VOP2 driver") > > Cc: stable@vger.kernel.org > > Signed-off-by: Sascha Hauer > > somehow we overlapped with this v2 and me applying the original one [0] > to drm-misc. With drm-misc being a shared tree there is also no way back. > > So if this v2 is better suited, could do a follow-up patch instead - on > top of your original one? Alright, just did that. You should find it in your inbox. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |