From: Boris Brezillon <boris.brezillon@collabora.com>
To: "Christian König" <christian.koenig@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>
Cc: Sarah Walker <sarah.walker@imgtec.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: drm/sched: Replacement for drm_sched_resubmit_jobs() is deprecated
Date: Tue, 2 May 2023 13:19:41 +0200 [thread overview]
Message-ID: <20230502131941.5fe5b79f@collabora.com> (raw)
Hello Christian, Alex,
As part of our transition to drm_sched for the powervr GPU driver, we
realized drm_sched_resubmit_jobs(), which is used by all drivers
relying on drm_sched right except amdgpu, has been deprecated.
Unfortunately, commit 5efbe6aa7a0e ("drm/scheduler: deprecate
drm_sched_resubmit_jobs") doesn't describe what drivers should do or use
as an alternative.
At the very least, for our implementation, we need to restore the
drm_sched_job::parent pointers that were set to NULL in
drm_sched_stop(), such that jobs submitted before the GPU recovery are
considered active when drm_sched_start() is called. That could be done
with a custom pending_list iteration restoring drm_sched_job::parent's
pointer, but that seems odd to let the scheduler backend manipulate
this list directly, and I suspect we need to do other checks, like the
karma vs hang-limit thing, so we can flag the entity dirty and cancel
all jobs being queued there if the entity has caused too many hangs.
Now that drm_sched_resubmit_jobs() has been deprecated, that would be
great if you could help us write a piece of documentation describing
what should be done between drm_sched_stop() and drm_sched_start(), so
new drivers don't come up with their own slightly different/broken
version of the same thing.
Thanks in advance for your help.
Regards,
Boris
next reply other threads:[~2023-05-02 11:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 11:19 Boris Brezillon [this message]
2023-05-02 11:36 ` drm/sched: Replacement for drm_sched_resubmit_jobs() is deprecated Christian König
2023-05-02 12:41 ` Boris Brezillon
2023-05-03 8:16 ` Boris Brezillon
2023-05-03 8:47 ` Christian König
2023-05-03 9:49 ` Boris Brezillon
2023-05-03 10:28 ` Lucas Stach
2023-05-03 11:40 ` Christian König
2023-05-03 13:10 ` Lucas Stach
2023-05-03 15:01 ` Christian König
2023-05-04 4:54 ` Matthew Brost
2023-05-04 11:07 ` Christian König
2023-05-04 13:07 ` Matthew Brost
2023-05-02 16:50 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230502131941.5fe5b79f@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=sarah.walker@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox