From: Lucas Stach <l.stach@pengutronix.de>
To: Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>
Cc: Marek Vasut <marex@denx.de>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Jonas Karlman <jonas@kwiboo.se>,
dri-devel@lists.freedesktop.org, patchwork-lst@pengutronix.de,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
kernel@pengutronix.de
Subject: [PATCH 1/2] drm: bridge: tc358767: increase PLL lock time delay
Date: Fri, 2 Jun 2023 21:15:00 +0200 [thread overview]
Message-ID: <20230602191501.4138433-1-l.stach@pengutronix.de> (raw)
From: David Jander <david@protonic.nl>
The PLL often fails to lock with this delay. The new value was
determined by trial and error increasing the delay bit by bit
until the error did not occurr anymore even after several tries.
Then double that value was taken as the minimum delay to be safe.
Signed-off-by: David Jander <david@protonic.nl>
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
drivers/gpu/drm/bridge/tc358767.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
index 91f7cb56a654..46916ae30f8f 100644
--- a/drivers/gpu/drm/bridge/tc358767.c
+++ b/drivers/gpu/drm/bridge/tc358767.c
@@ -501,7 +501,7 @@ static int tc_pllupdate(struct tc_data *tc, unsigned int pllctrl)
return ret;
/* Wait for PLL to lock: up to 2.09 ms, depending on refclk */
- usleep_range(3000, 6000);
+ usleep_range(15000, 20000);
return 0;
}
--
2.39.2
next reply other threads:[~2023-06-02 19:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 19:15 Lucas Stach [this message]
2023-06-02 19:15 ` [PATCH 2/2] drm: bridge: tc358767: give VSDELAY some positive value Lucas Stach
2023-06-02 21:34 ` Marek Vasut
2023-06-07 12:53 ` Lucas Stach
2023-06-07 13:54 ` Marek Vasut
2023-06-08 8:11 ` Lucas Stach
2023-07-08 19:01 ` Marek Vasut
2023-06-02 21:31 ` [PATCH 1/2] drm: bridge: tc358767: increase PLL lock time delay Marek Vasut
2023-07-08 19:02 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230602191501.4138433-1-l.stach@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel@pengutronix.de \
--cc=marex@denx.de \
--cc=neil.armstrong@linaro.org \
--cc=patchwork-lst@pengutronix.de \
--cc=rfoss@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).