From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D646EB64D8 for ; Tue, 20 Jun 2023 16:48:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 11C4010E310; Tue, 20 Jun 2023 16:48:24 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1116610E304 for ; Tue, 20 Jun 2023 16:48:21 +0000 (UTC) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 05F20B2A; Tue, 20 Jun 2023 18:47:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1687279666; bh=n6szjPbzctfFO2eL46Qs3m2ddroPrcA/e5XpeGrnJTM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oNOh5R2HHEl4+NNt0N0uTWOqgYKFTZbVThLpNE8jy7qIgadxEc/RTVyZCwbk8GOpq 7cNGu8guZHypWWWvh2jAIO5tgzW1anOwWvlL/2K5wgPpToJITbIjcVhp6k2eqYQKnc y9dQDTGTIwX4W2XLXzqLvdtCVrMOILWnKyQE4FVI= Date: Tue, 20 Jun 2023 19:48:19 +0300 From: Laurent Pinchart To: Thomas Zimmermann Subject: Re: [PATCH 3/3] drm/gem-dma: Unexport drm_gem_dma_vm_ops Message-ID: <20230620164819.GF26467@pendragon.ideasonboard.com> References: <20230620121202.28263-1-tzimmermann@suse.de> <20230620121202.28263-4-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230620121202.28263-4-tzimmermann@suse.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: hjc@rock-chips.com, mripard@kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, kieran.bingham+renesas@ideasonboard.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Thomas, Thank you for the patch. On Tue, Jun 20, 2023 at 02:03:23PM +0200, Thomas Zimmermann wrote: > There are no external users of drm_gem_dma_vm_ops. Unexport the symbol. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/drm_gem_dma_helper.c | 11 +++++------ > include/drm/drm_gem_dma_helper.h | 2 -- > 2 files changed, 5 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/drm_gem_dma_helper.c b/drivers/gpu/drm/drm_gem_dma_helper.c > index e9aa3ac140654..d8a415c3d156c 100644 > --- a/drivers/gpu/drm/drm_gem_dma_helper.c > +++ b/drivers/gpu/drm/drm_gem_dma_helper.c > @@ -45,6 +45,11 @@ > * drm_gem_dma_vmap()). These helpers perform the necessary type conversion. > */ > > +static const struct vm_operations_struct drm_gem_dma_vm_ops = { > + .open = drm_gem_vm_open, > + .close = drm_gem_vm_close, > +}; > + > static const struct drm_gem_object_funcs drm_gem_dma_default_funcs = { > .free = drm_gem_dma_object_free, > .print_info = drm_gem_dma_object_print_info, > @@ -315,12 +320,6 @@ int drm_gem_dma_dumb_create(struct drm_file *file_priv, > } > EXPORT_SYMBOL_GPL(drm_gem_dma_dumb_create); > > -const struct vm_operations_struct drm_gem_dma_vm_ops = { > - .open = drm_gem_vm_open, > - .close = drm_gem_vm_close, > -}; > -EXPORT_SYMBOL_GPL(drm_gem_dma_vm_ops); > - > #ifndef CONFIG_MMU > /** > * drm_gem_dma_get_unmapped_area - propose address for mapping in noMMU cases > diff --git a/include/drm/drm_gem_dma_helper.h b/include/drm/drm_gem_dma_helper.h > index 3877cbf0e927c..88a810f954fce 100644 > --- a/include/drm/drm_gem_dma_helper.h > +++ b/include/drm/drm_gem_dma_helper.h > @@ -45,8 +45,6 @@ int drm_gem_dma_vmap(struct drm_gem_dma_object *dma_obj, > struct iosys_map *map); > int drm_gem_dma_mmap(struct drm_gem_dma_object *dma_obj, struct vm_area_struct *vma); > > -extern const struct vm_operations_struct drm_gem_dma_vm_ops; > - > /* > * GEM object functions > */ -- Regards, Laurent Pinchart