dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Zack Rusin <zack@kde.org>
To: dri-devel@lists.freedesktop.org
Cc: Hans de Goede <hdegoede@redhat.com>,
	David Airlie <airlied@linux.ie>,
	javierm@redhat.com, banackm@vmware.com, krastevm@vmware.com,
	ppaalanen@gmail.com, iforbes@vmware.com, mombasawalam@vmware.com
Subject: [PATCH v3 5/8] drm/vboxvideo: Use the hotspot properties from cursor planes
Date: Mon, 26 Jun 2023 23:58:36 -0400	[thread overview]
Message-ID: <20230627035839.496399-6-zack@kde.org> (raw)
In-Reply-To: <20230627035839.496399-1-zack@kde.org>

From: Zack Rusin <zackr@vmware.com>

Atomic modesetting got support for mouse hotspots via the hotspot
properties. Port the legacy kms hotspot handling to the new properties
on cursor planes.

Signed-off-by: Zack Rusin <zackr@vmware.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
---
 drivers/gpu/drm/vboxvideo/vbox_mode.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/vboxvideo/vbox_mode.c b/drivers/gpu/drm/vboxvideo/vbox_mode.c
index 341edd982cb3..9ff3bade9795 100644
--- a/drivers/gpu/drm/vboxvideo/vbox_mode.c
+++ b/drivers/gpu/drm/vboxvideo/vbox_mode.c
@@ -429,8 +429,8 @@ static void vbox_cursor_atomic_update(struct drm_plane *plane,
 	flags = VBOX_MOUSE_POINTER_VISIBLE | VBOX_MOUSE_POINTER_SHAPE |
 		VBOX_MOUSE_POINTER_ALPHA;
 	hgsmi_update_pointer_shape(vbox->guest_pool, flags,
-				   min_t(u32, max(fb->hot_x, 0), width),
-				   min_t(u32, max(fb->hot_y, 0), height),
+				   min_t(u32, max(new_state->hotspot_x, 0), width),
+				   min_t(u32, max(new_state->hotspot_y, 0), height),
 				   width, height, vbox->cursor_data, data_size);
 
 	mutex_unlock(&vbox->hw_mutex);
-- 
2.39.2


  parent reply	other threads:[~2023-06-27  3:59 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-27  3:58 [PATCH v3 0/8] Fix cursor planes with virtualized drivers Zack Rusin
2023-06-27  3:58 ` [PATCH v3 1/8] drm: Disable the cursor plane on atomic contexts " Zack Rusin
2023-06-27  8:18   ` Pekka Paalanen
2023-06-27  8:26   ` Javier Martinez Canillas
2023-06-27  3:58 ` [PATCH v3 2/8] drm/atomic: Add support for mouse hotspots Zack Rusin
2023-06-27  8:26   ` Pekka Paalanen
2023-06-27  8:56     ` Javier Martinez Canillas
2023-06-27 10:30       ` Pekka Paalanen
2023-06-27 10:54         ` Javier Martinez Canillas
2023-06-27  8:49   ` Javier Martinez Canillas
2023-06-27  3:58 ` [PATCH v3 3/8] drm/vmwgfx: Use the hotspot properties from cursor planes Zack Rusin
2023-06-27  9:49   ` Javier Martinez Canillas
2023-06-27 13:08   ` Martin Krastev (VMware)
2023-06-27  3:58 ` [PATCH v3 4/8] drm/qxl: " Zack Rusin
2023-06-27  9:50   ` Javier Martinez Canillas
2023-06-27  3:58 ` Zack Rusin [this message]
2023-06-27 10:02   ` [PATCH v3 5/8] drm/vboxvideo: " Javier Martinez Canillas
2023-06-27  3:58 ` [PATCH v3 6/8] drm/virtio: " Zack Rusin
2023-06-27 10:03   ` Javier Martinez Canillas
2023-06-27  3:58 ` [PATCH v3 7/8] drm: Remove legacy cursor hotspot code Zack Rusin
2023-06-27 10:16   ` Javier Martinez Canillas
2023-06-27  3:58 ` [PATCH v3 8/8] drm: Introduce DRM_CLIENT_CAP_VIRTUALIZED_CURSOR_PLANE Zack Rusin
2023-06-27  8:38   ` Pekka Paalanen
2023-06-27 10:19   ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230627035839.496399-6-zack@kde.org \
    --to=zack@kde.org \
    --cc=airlied@linux.ie \
    --cc=banackm@vmware.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hdegoede@redhat.com \
    --cc=iforbes@vmware.com \
    --cc=javierm@redhat.com \
    --cc=krastevm@vmware.com \
    --cc=mombasawalam@vmware.com \
    --cc=ppaalanen@gmail.com \
    --cc=zackr@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).