dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Zack Rusin <zack@kde.org>
To: dri-devel@lists.freedesktop.org
Cc: Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@linux.ie>,
	javierm@redhat.com, banackm@vmware.com, krastevm@vmware.com,
	ppaalanen@gmail.com, iforbes@vmware.com, mombasawalam@vmware.com
Subject: [PATCH v3 7/8] drm: Remove legacy cursor hotspot code
Date: Mon, 26 Jun 2023 23:58:38 -0400	[thread overview]
Message-ID: <20230627035839.496399-8-zack@kde.org> (raw)
In-Reply-To: <20230627035839.496399-1-zack@kde.org>

From: Zack Rusin <zackr@vmware.com>

Atomic modesetting support mouse cursor offsets via the hotspot
properties that are creates on cursor planes. All drivers which
support hotspot are atomic and the legacy code has been implemented
in terms of the atomic properties as well.

Due to the above the lagacy cursor hotspot code is no longer used or
needed and can be removed.

Signed-off-by: Zack Rusin <zackr@vmware.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
---
 drivers/gpu/drm/drm_plane.c   |  3 ---
 include/drm/drm_framebuffer.h | 12 ------------
 2 files changed, 15 deletions(-)

diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c
index ff1cc810d8f8..539fe0d94300 100644
--- a/drivers/gpu/drm/drm_plane.c
+++ b/drivers/gpu/drm/drm_plane.c
@@ -1069,9 +1069,6 @@ static int drm_mode_cursor_universal(struct drm_crtc *crtc,
 				return PTR_ERR(fb);
 			}
 
-			fb->hot_x = req->hot_x;
-			fb->hot_y = req->hot_y;
-
 			if (plane->hotspot_x_property && plane->state)
 				plane->state->hotspot_x = req->hot_x;
 			if (plane->hotspot_y_property && plane->state)
diff --git a/include/drm/drm_framebuffer.h b/include/drm/drm_framebuffer.h
index 0dcc07b68654..1e108c1789b1 100644
--- a/include/drm/drm_framebuffer.h
+++ b/include/drm/drm_framebuffer.h
@@ -188,18 +188,6 @@ struct drm_framebuffer {
 	 * DRM_MODE_FB_MODIFIERS.
 	 */
 	int flags;
-	/**
-	 * @hot_x: X coordinate of the cursor hotspot. Used by the legacy cursor
-	 * IOCTL when the driver supports cursor through a DRM_PLANE_TYPE_CURSOR
-	 * universal plane.
-	 */
-	int hot_x;
-	/**
-	 * @hot_y: Y coordinate of the cursor hotspot. Used by the legacy cursor
-	 * IOCTL when the driver supports cursor through a DRM_PLANE_TYPE_CURSOR
-	 * universal plane.
-	 */
-	int hot_y;
 	/**
 	 * @filp_head: Placed on &drm_file.fbs, protected by &drm_file.fbs_lock.
 	 */
-- 
2.39.2


  parent reply	other threads:[~2023-06-27  3:59 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-27  3:58 [PATCH v3 0/8] Fix cursor planes with virtualized drivers Zack Rusin
2023-06-27  3:58 ` [PATCH v3 1/8] drm: Disable the cursor plane on atomic contexts " Zack Rusin
2023-06-27  8:18   ` Pekka Paalanen
2023-06-27  8:26   ` Javier Martinez Canillas
2023-06-27  3:58 ` [PATCH v3 2/8] drm/atomic: Add support for mouse hotspots Zack Rusin
2023-06-27  8:26   ` Pekka Paalanen
2023-06-27  8:56     ` Javier Martinez Canillas
2023-06-27 10:30       ` Pekka Paalanen
2023-06-27 10:54         ` Javier Martinez Canillas
2023-06-27  8:49   ` Javier Martinez Canillas
2023-06-27  3:58 ` [PATCH v3 3/8] drm/vmwgfx: Use the hotspot properties from cursor planes Zack Rusin
2023-06-27  9:49   ` Javier Martinez Canillas
2023-06-27 13:08   ` Martin Krastev (VMware)
2023-06-27  3:58 ` [PATCH v3 4/8] drm/qxl: " Zack Rusin
2023-06-27  9:50   ` Javier Martinez Canillas
2023-06-27  3:58 ` [PATCH v3 5/8] drm/vboxvideo: " Zack Rusin
2023-06-27 10:02   ` Javier Martinez Canillas
2023-06-27  3:58 ` [PATCH v3 6/8] drm/virtio: " Zack Rusin
2023-06-27 10:03   ` Javier Martinez Canillas
2023-06-27  3:58 ` Zack Rusin [this message]
2023-06-27 10:16   ` [PATCH v3 7/8] drm: Remove legacy cursor hotspot code Javier Martinez Canillas
2023-06-27  3:58 ` [PATCH v3 8/8] drm: Introduce DRM_CLIENT_CAP_VIRTUALIZED_CURSOR_PLANE Zack Rusin
2023-06-27  8:38   ` Pekka Paalanen
2023-06-27 10:19   ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230627035839.496399-8-zack@kde.org \
    --to=zack@kde.org \
    --cc=airlied@linux.ie \
    --cc=banackm@vmware.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=iforbes@vmware.com \
    --cc=javierm@redhat.com \
    --cc=krastevm@vmware.com \
    --cc=mombasawalam@vmware.com \
    --cc=mripard@kernel.org \
    --cc=ppaalanen@gmail.com \
    --cc=tzimmermann@suse.de \
    --cc=zackr@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).