From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 799E5C0015E for ; Tue, 25 Jul 2023 07:47:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9F4C189153; Tue, 25 Jul 2023 07:47:08 +0000 (UTC) Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by gabe.freedesktop.org (Postfix) with ESMTPS id DFC1489153 for ; Tue, 25 Jul 2023 07:47:06 +0000 (UTC) Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by madras.collabora.co.uk (Postfix) with ESMTPSA id DC12066015A0; Tue, 25 Jul 2023 08:47:04 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1690271225; bh=FqkQljsrQQYOynoMT2kuaNXBVI9Ga1goxxlMyTMz8vw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TpVqrT9yeALla9A5G8KsleNW0whIR/H/Z7xqayb6QGZmAsHfE91SHNvep7FB7R3ww fF5BxvA3MWogzwUihj5xkXJLBwV0NGQNSsiovbDAOGm207wFLqm8nDBPeHp2SRwQHQ v5RC1zPn8ZquR8Y7sCR0a6+0wgrZeCNbISd4ruSWFxkCK2r49WnG9cFMVVoqaaowX9 +WYJG72rZ+GKWdT+s3xIZdTon+KyaeEIZw2mLXqh9CazPCfuZzN+WYL+36aR76AkRs +VbJW1HOmaxxIx67dn9a1ljF/lMWNsQG4fCtPxQnWFROSRkfK0aAjGOcjISNiIjKus uNx7TKYgVA/pQ== Date: Tue, 25 Jul 2023 09:47:02 +0200 From: Boris Brezillon To: Dmitry Osipenko Subject: Re: [PATCH v14 10/12] drm/shmem-helper: Refactor locked/unlocked functions Message-ID: <20230725094702.4322fbb5@collabora.com> In-Reply-To: <20230722234746.205949-11-dmitry.osipenko@collabora.com> References: <20230722234746.205949-1-dmitry.osipenko@collabora.com> <20230722234746.205949-11-dmitry.osipenko@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel@collabora.com, Thomas Zimmermann , Emma Anholt , Christian =?UTF-8?B?S8O2bmln?= , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , Gurchetan Singh , Melissa Wen , Gerd Hoffmann , Steven Price , virtualization@lists.linux-foundation.org, Qiang Yu Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, 23 Jul 2023 02:47:44 +0300 Dmitry Osipenko wrote: > Add locked/unlocked postfixes to drm-shmem function names to make clear > where reservation lock is taken and where not. Uh, ignore my comment on patch 1 then... > Add more common helpers to drm_gem_shmem_helper.h I'd do the renaming and exporting in separate patches. > > Suggested-by: Boris Brezillon > Signed-off-by: Dmitry Osipenko