From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08003C001DC for ; Wed, 26 Jul 2023 08:12:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2A27410E438; Wed, 26 Jul 2023 08:12:37 +0000 (UTC) Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by gabe.freedesktop.org (Postfix) with ESMTPS id E486010E438 for ; Wed, 26 Jul 2023 08:12:34 +0000 (UTC) Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by madras.collabora.co.uk (Postfix) with ESMTPSA id 39C836607115; Wed, 26 Jul 2023 09:12:33 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1690359153; bh=bv+7ZUUelb6V7kHZSaClncJveuGHmyoAZiGkqY3gwF4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bFlBHTMDAGDYXduXXP9jJePvuEvcSNTlEojL9ZviFmwhfy9akUKmmPaugfPgl2c+H gCmKqc29njcJLqJLQDNFm9B42kDqyHgPl/hnNdCAaA7pJHZPo+hciOo2/B10YqFBij MaaKxS3rh7NEkAhKG8K3cnL32l/c/rx3PIDF7Qb7eiu4RIbpecdJYANFl/a88fPmn3 pgMb7GR/ClvDExJGvA13B8HFZ/OqW4L5DHtGrD3zj4ze4UzfW8L6sVPtuUqotuQul0 +p9pDhg0GPTmFKeRb7EjnNDZyfbNTwdWws7kUhEpPYmFU4EUSQXh1kIhqY0peOjDyj Sx2Ex1B51NzHA== Date: Wed, 26 Jul 2023 10:12:30 +0200 From: Boris Brezillon To: Danilo Krummrich Subject: Re: [drm-misc:for-linux-next 2/2] drivers/gpu/drm/drm_debugfs.c:212:33: sparse: sparse: non size-preserving pointer to integer cast Message-ID: <20230726101230.6e7d2eb1@collabora.com> In-Reply-To: <9d49d9b1-1db8-63c9-b0f6-aa72904f6aaa@redhat.com> References: <202307210230.t2OnM5g0-lkp@intel.com> <20230724092744.5c5b5700@collabora.com> <9d49d9b1-1db8-63c9-b0f6-aa72904f6aaa@redhat.com> Organization: Collabora X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , kernel test robot , dri-devel@lists.freedesktop.org, oe-kbuild-all@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 26 Jul 2023 00:25:36 +0200 Danilo Krummrich wrote: > On 7/24/23 09:27, Boris Brezillon wrote: > > On Fri, 21 Jul 2023 02:06:16 +0800 > > kernel test robot wrote: > > > >> tree: git://anongit.freedesktop.org/drm/drm-misc for-linux-next > >> head: c7a472297169156252a50d76965eb36b081186e2 > >> commit: 4f66feeab173bd73e71028b8c2e1dcea07e32dd5 [2/2] drm: debugfs: provide infrastructure to dump a DRM GPU VA space > >> config: i386-randconfig-r092-20230720 (https://download.01.org/0day-ci/archive/20230721/202307210230.t2OnM5g0-lkp@intel.com/config) > >> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 > >> reproduce: (https://download.01.org/0day-ci/archive/20230721/202307210230.t2OnM5g0-lkp@intel.com/reproduce) > >> > >> If you fix the issue in a separate patch/commit (i.e. not just a new version of > >> the same patch/commit), kindly add following tags > >> | Reported-by: kernel test robot > >> | Closes: https://lore.kernel.org/oe-kbuild-all/202307210230.t2OnM5g0-lkp@intel.com/ > >> > >> sparse warnings: (new ones prefixed by >>) > >>>> drivers/gpu/drm/drm_debugfs.c:212:33: sparse: sparse: non size-preserving pointer to integer cast > >> > >> vim +212 drivers/gpu/drm/drm_debugfs.c > >> > >> 178 > >> 179 /** > >> 180 * drm_debugfs_gpuva_info - dump the given DRM GPU VA space > >> 181 * @m: pointer to the &seq_file to write > >> 182 * @mgr: the &drm_gpuva_manager representing the GPU VA space > >> 183 * > >> 184 * Dumps the GPU VA mappings of a given DRM GPU VA manager. > >> 185 * > >> 186 * For each DRM GPU VA space drivers should call this function from their > >> 187 * &drm_info_list's show callback. > >> 188 * > >> 189 * Returns: 0 on success, -ENODEV if the &mgr is not initialized > >> 190 */ > >> 191 int drm_debugfs_gpuva_info(struct seq_file *m, > >> 192 struct drm_gpuva_manager *mgr) > >> 193 { > >> 194 struct drm_gpuva *va, *kva = &mgr->kernel_alloc_node; > >> 195 > >> 196 if (!mgr->name) > >> 197 return -ENODEV; > >> 198 > >> 199 seq_printf(m, "DRM GPU VA space (%s) [0x%016llx;0x%016llx]\n", > >> 200 mgr->name, mgr->mm_start, mgr->mm_start + mgr->mm_range); > >> 201 seq_printf(m, "Kernel reserved node [0x%016llx;0x%016llx]\n", > >> 202 kva->va.addr, kva->va.addr + kva->va.range); > >> 203 seq_puts(m, "\n"); > >> 204 seq_puts(m, " VAs | start | range | end | object | object offset\n"); > >> 205 seq_puts(m, "-------------------------------------------------------------------------------------------------------------\n"); > >> 206 drm_gpuva_for_each_va(va, mgr) { > >> 207 if (unlikely(va == kva)) > >> 208 continue; > >> 209 > >> 210 seq_printf(m, " | 0x%016llx | 0x%016llx | 0x%016llx | 0x%016llx | 0x%016llx\n", > >> 211 va->va.addr, va->va.range, va->va.addr + va->va.range, > >> > 212 (u64)va->gem.obj, va->gem.offset); > > > > Oops, I didn't notice it when reviewing. You're leaking a kernel address > > to user space here. You should probably use %p to print the GEM object > > address, and add `no_hash_pointers` to your cmdline when you want to > > debug things. > > %p doesn't really work well in terms of formatting, plus for debugfs I > thought this might be fine. I could maybe use ptr_to_hashval(), but then > 'no_hash_pointers' wouldn't do anything for it. Right, it's probably fine for debugfs indeed. Guess the uintptr_t cast Steve suggested is the right fix then.