dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Cromie <jim.cromie@gmail.com>
To: jbaron@akamai.com, daniel.vetter@ffwll.ch,
	dri-devel@lists.freedesktop.org
Subject: [PATCH v5 10/23] dyndbg: tighten ddebug_class_name() 1st arg type
Date: Tue,  1 Aug 2023 17:34:56 -0600	[thread overview]
Message-ID: <20230801233515.166971-11-jim.cromie@gmail.com> (raw)
In-Reply-To: <20230801233515.166971-1-jim.cromie@gmail.com>

Change function's 1st arg-type, and deref in the caller.
The fn doesn't need any other fields in the struct.

no functional change.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
 lib/dynamic_debug.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 7430add36423..5139c8d45d12 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -1113,12 +1113,12 @@ static void *ddebug_proc_next(struct seq_file *m, void *p, loff_t *pos)
 #define class_in_range(class_id, map)					\
 	(class_id >= map->base && class_id < map->base + map->length)
 
-static const char *ddebug_class_name(struct ddebug_iter *iter, struct _ddebug *dp)
+static const char *ddebug_class_name(struct ddebug_table *dt, struct _ddebug *dp)
 {
-	struct ddebug_class_map *map = iter->table->classes;
-	int i, nc = iter->table->num_classes;
+	struct ddebug_class_map *map = dt->classes;
+	int i;
 
-	for (i = 0; i < nc; i++, map++)
+	for (i = 0; i < dt->num_classes; i++, map++)
 		if (class_in_range(dp->class_id, map))
 			return map->class_names[dp->class_id - map->base];
 
@@ -1152,7 +1152,7 @@ static int ddebug_proc_show(struct seq_file *m, void *p)
 	seq_puts(m, "\"");
 
 	if (dp->class_id != _DPRINTK_CLASS_DFLT) {
-		class = ddebug_class_name(iter, dp);
+		class = ddebug_class_name(iter->table, dp);
 		if (class)
 			seq_printf(m, " class:%s", class);
 		else
-- 
2.41.0


  parent reply	other threads:[~2023-08-01 23:35 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-01 23:34 [PATCH v5 00/22] fix DRM_USE_DYNAMIC_DEBUG regression Jim Cromie
2023-08-01 23:34 ` [PATCH v5 01/23] drm: use correct ccflags-y syntax Jim Cromie
2023-08-01 23:34 ` [PATCH v5 02/23] test-dyndbg: fixup CLASSMAP usage error Jim Cromie
2023-08-01 23:34 ` [PATCH v5 03/23] dyndbg: make ddebug_class_param union members same size Jim Cromie
2023-08-01 23:34 ` [PATCH v5 04/23] dyndbg: replace classmap list with a vector Jim Cromie
2023-08-01 23:34 ` [PATCH v5 05/23] dyndbg: ddebug_apply_class_bitmap - add module arg, select on it Jim Cromie
2023-08-01 23:34 ` [PATCH v5 06/23] dyndbg: split param_set_dyndbg_classes to module/wrapper fns Jim Cromie
2023-08-01 23:34 ` [PATCH v5 07/23] dyndbg: drop NUM_TYPE_ARRAY Jim Cromie
2023-08-01 23:34 ` [PATCH v5 08/23] dyndbg: reduce verbose/debug clutter Jim Cromie
2023-08-01 23:34 ` [PATCH v5 09/23] dyndbg: silence debugs with no-change updates Jim Cromie
2023-08-01 23:34 ` Jim Cromie [this message]
2023-08-01 23:34 ` [PATCH v5 11/23] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap Jim Cromie
2023-08-01 23:34 ` [PATCH v5 12/23] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code Jim Cromie
2023-08-01 23:34 ` [PATCH v5 13/22] checkpatch: file-scoped extern special case for linker-symbol Jim Cromie
2023-08-01 23:35 ` [PATCH v5 13/23] checkpatch: special case for file-scoped extern linker-symbol Jim Cromie
2023-08-01 23:35 ` [PATCH v5 14/23] dyndbg-API: fix CONFIG_DRM_USE_DYNAMIC_DEBUG regression Jim Cromie
2023-08-01 23:35 ` [PATCH v5 15/23] dyndbg: add for_each_boxed_vector Jim Cromie
2023-08-01 23:35 ` [PATCH v5 16/23] dyndbg: refactor ddebug_classparam_clamp_input Jim Cromie
2023-08-01 23:35 ` [PATCH v5 17/23] dyndbg-API: promote DYNDBG_CLASSMAP_PARAM to API Jim Cromie
2023-08-01 23:35 ` [PATCH v5 18/22] dyndbg-test: build it with just CONFIG_DYNAMIC_DEBUG_CORE Jim Cromie
2023-08-01 23:35 ` [PATCH v5 18/23] parens-on-PARAM Jim Cromie
2023-08-01 23:35 ` [PATCH v5 19/22] drm: restore CONFIG_DRM_USE_DYNAMIC_DEBUG un-BROKEN Jim Cromie
2023-08-01 23:35 ` [PATCH v5 19/23] dyndbg-test: build it with just CONFIG_DYNAMIC_DEBUG_CORE Jim Cromie
2023-08-01 23:35 ` [PATCH v5 20/22] drm-drivers: DRM_CLASSMAP_USE in 2nd batch of drivers, helpers Jim Cromie
2023-08-01 23:35 ` [PATCH v5 20/23] drm: restore CONFIG_DRM_USE_DYNAMIC_DEBUG un-BROKEN Jim Cromie
2023-08-01 23:35 ` [PATCH v5 21/23] drm-drivers: DRM_CLASSMAP_USE in 2nd batch of drivers, helpers Jim Cromie
2023-08-01 23:35 ` [PATCH v5 21/22] dyndbg-doc: add classmap info to howto Jim Cromie
2023-08-01 23:35 ` [PATCH v5 22/22] checkpatch: reword long-line warn about commit-msg Jim Cromie
2023-08-01 23:55   ` Joe Perches
2023-08-01 23:35 ` [PATCH v5 22/23] dyndbg-doc: add classmap info to howto Jim Cromie
2023-08-01 23:35 ` [PATCH v5 23/23] checkpatch: reword long-line warn about commit-msg Jim Cromie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230801233515.166971-11-jim.cromie@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jbaron@akamai.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox