dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Wayne Lin <Wayne.Lin@amd.com>
To: <dri-devel@lists.freedesktop.org>, <amd-gfx@lists.freedesktop.org>
Cc: jani.nikula@intel.com, jerry.zuo@amd.com, Wayne Lin <Wayne.Lin@amd.com>
Subject: [PATCH 1/3] drm/mst: delete unnecessary case in drm_dp_add_payload_part2()
Date: Fri, 4 Aug 2023 14:20:27 +0800	[thread overview]
Message-ID: <20230804062029.5686-2-Wayne.Lin@amd.com> (raw)
In-Reply-To: <20230804062029.5686-1-Wayne.Lin@amd.com>

[Why]
There is no need to consider payload->delete case since we won't call
drm_dp_add_payload_part2() to create a payload when we're about to
remove it.

[How]
Delete unnecessary case to simplify the code.

Signed-off-by: Wayne Lin <Wayne.Lin@amd.com>
---
 drivers/gpu/drm/display/drm_dp_mst_topology.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c
index ed96cfcfa304..4d80426757ab 100644
--- a/drivers/gpu/drm/display/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c
@@ -3411,12 +3411,8 @@ int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr,
 
 	ret = drm_dp_create_payload_step2(mgr, payload);
 	if (ret < 0) {
-		if (!payload->delete)
-			drm_err(mgr->dev, "Step 2 of creating MST payload for %p failed: %d\n",
-				payload->port, ret);
-		else
-			drm_dbg_kms(mgr->dev, "Step 2 of removing MST payload for %p failed: %d\n",
-				    payload->port, ret);
+		drm_err(mgr->dev, "Step 2 of creating MST payload for %p failed: %d\n",
+			payload->port, ret);
 	}
 
 	return ret;
-- 
2.37.3


  reply	other threads:[~2023-08-04  6:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-04  6:20 [PATCH 0/3] Refactor and clean up codes of mst Wayne Lin
2023-08-04  6:20 ` Wayne Lin [this message]
2023-08-04  6:20 ` [PATCH 2/3] drm/mst: Refactor the flow for payload allocation/removement Wayne Lin
2023-08-04  9:19   ` kernel test robot
2023-08-04 14:47   ` kernel test robot
2023-08-04  6:20 ` [PATCH 3/3] drm/mst: adjust the function drm_dp_remove_payload_part2() Wayne Lin
2023-08-04 15:31   ` Imre Deak
2023-08-07  2:43     ` Lin, Wayne
2023-08-07 15:59       ` Imre Deak
2023-08-08  3:47         ` Lin, Wayne
2023-08-18 17:46           ` Imre Deak
2023-08-23  3:16             ` Lin, Wayne
2023-08-25 13:55               ` Imre Deak
2023-09-07  3:44                 ` Lin, Wayne
2023-09-08 19:18                   ` Imre Deak
2023-09-12  7:26                     ` Lin, Wayne
2023-09-12 11:18                       ` Imre Deak
2023-09-14  3:29                         ` Lin, Wayne
2023-08-17 21:38         ` Lyude Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230804062029.5686-2-Wayne.Lin@amd.com \
    --to=wayne.lin@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=jerry.zuo@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox