From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7B68E7109E for ; Wed, 27 Sep 2023 22:35:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D966C10E12F; Wed, 27 Sep 2023 22:35:04 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2393610E12F for ; Wed, 27 Sep 2023 22:35:02 +0000 (UTC) Received: from pendragon.ideasonboard.com (176-132-227-79.abo.bbox.fr [176.132.227.79]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C83FADFB; Thu, 28 Sep 2023 00:33:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1695853998; bh=tgAM6hIf8vOK+JbAL7Vltz95go7SSxBCMXgYon6UG5w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oZIyfWeNWzFWcCxiWW3ZuR2voup+13/CqIpCfzRQHZS5757xYYoKIoOUPi/OkA8Sg vgRP7qEIRQ3xJeKySuyVVs4ej5Zccm2qNL78Py5W4OPBuNRjLyyPLYjXoC8kXBSBYK Puc+rMXp324F+g5tsfoGAOtW7pyF0o4CnEitbEC8= Date: Thu, 28 Sep 2023 01:35:10 +0300 From: Laurent Pinchart To: Jani Nikula Subject: Re: [PATCH 2/2] drm/bridge: lt9611uxc: use drm_bridge_get_edid() instead of using ->get_edid directly Message-ID: <20230927223510.GY5854@pendragon.ideasonboard.com> References: <20230914131450.2473061-1-jani.nikula@intel.com> <20230914131450.2473061-2-jani.nikula@intel.com> <20230927113058.GA8079@pendragon.ideasonboard.com> <87lecrk8rw.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87lecrk8rw.fsf@intel.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , dri-devel@lists.freedesktop.org, Andrzej Hajda Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Sep 27, 2023 at 05:09:23PM +0300, Jani Nikula wrote: > On Wed, 27 Sep 2023, Laurent Pinchart wrote: > > On Thu, Sep 14, 2023 at 04:14:50PM +0300, Jani Nikula wrote: > >> Make drm_bridge_get_edid() the one place to call the hook. > >> > >> Cc: Andrzej Hajda > >> Cc: Neil Armstrong > >> Cc: Robert Foss > >> Cc: Laurent Pinchart > >> Cc: Jonas Karlman > >> Cc: Jernej Skrabec > >> Signed-off-by: Jani Nikula > >> > >> --- > >> > >> UNTESTED > > > > I can't test this either, but it looks fine. > > Thanks. Are you okay with merging the two with review only? The changes are trivial, if we can't get anyone to test them, then I'm OK merging them. > > Reviewed-by: Laurent Pinchart > > > >> --- > >> drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c > >> index 22c84d29c2bc..7835738a532e 100644 > >> --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c > >> +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c > >> @@ -296,7 +296,7 @@ static int lt9611uxc_connector_get_modes(struct drm_connector *connector) > >> unsigned int count; > >> struct edid *edid; > >> > >> - edid = lt9611uxc->bridge.funcs->get_edid(<9611uxc->bridge, connector); > >> + edid = drm_bridge_get_edid(<9611uxc->bridge, connector); > >> drm_connector_update_edid_property(connector, edid); > >> count = drm_add_edid_modes(connector, edid); > >> kfree(edid); -- Regards, Laurent Pinchart