Re: [PATCH v3] drm/atomic-helpers: Invoke end_fb_access while owning plane state

[kernel test robot <lkp@intel.com>]

Hi Thomas,

kernel test robot noticed the following build warnings:

[auto build test WARNING on drm-misc/drm-misc-next]
[also build test WARNING on drm-intel/for-linux-next drm-intel/for-linux-next-fixes linus/master v6.7-rc3 next-20231128]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/drm-atomic-helpers-Invoke-end_fb_access-while-owning-plane-state/20231128-170429
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:    https://lore.kernel.org/r/20231128090158.15564-1-tzimmermann%40suse.de
patch subject: [PATCH v3] drm/atomic-helpers: Invoke end_fb_access while owning plane state
config: i386-buildonly-randconfig-002-20231128 (https://download.01.org/0day-ci/archive/20231128/202311282308.nZrBqKpT-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231128/202311282308.nZrBqKpT-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311282308.nZrBqKpT-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/drm_atomic_helper.c:2665: warning: Function parameter or member 'state' not described in 'drm_atomic_helper_unprepare_planes'
>> drivers/gpu/drm/drm_atomic_helper.c:2665: warning: Excess function parameter 'old_state' description in 'drm_atomic_helper_unprepare_planes'


vim +2665 drivers/gpu/drm/drm_atomic_helper.c

  2652	
  2653	/**
  2654	 * drm_atomic_helper_unprepare_planes - release plane resources on aborts
  2655	 * @dev: DRM device
  2656	 * @old_state: atomic state object with old state structures
  2657	 *
  2658	 * This function cleans up plane state, specifically framebuffers, from the
  2659	 * atomic state. It undoes the effects of drm_atomic_helper_prepare_planes()
  2660	 * when aborting an atomic commit. For cleaning up after a successful commit
  2661	 * use drm_atomic_helper_cleanup_planes().
  2662	 */
  2663	void drm_atomic_helper_unprepare_planes(struct drm_device *dev,
  2664						struct drm_atomic_state *state)
> 2665	{
  2666		struct drm_plane *plane;
  2667		struct drm_plane_state *new_plane_state;
  2668		int i;
  2669	
  2670		for_each_new_plane_in_state(state, plane, new_plane_state, i) {
  2671			const struct drm_plane_helper_funcs *funcs = plane->helper_private;
  2672	
  2673			if (funcs->end_fb_access)
  2674				funcs->end_fb_access(plane, new_plane_state);
  2675		}
  2676	
  2677		for_each_new_plane_in_state(state, plane, new_plane_state, i) {
  2678			const struct drm_plane_helper_funcs *funcs = plane->helper_private;
  2679	
  2680			if (funcs->cleanup_fb)
  2681				funcs->cleanup_fb(plane, new_plane_state);
  2682		}
  2683	}
  2684	EXPORT_SYMBOL(drm_atomic_helper_unprepare_planes);
  2685	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki