From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 302F6C47422 for ; Fri, 26 Jan 2024 07:46:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9174010E888; Fri, 26 Jan 2024 07:46:51 +0000 (UTC) Received: from mail5.25mail.st (mail5.25mail.st [74.50.62.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 14C1210E888 for ; Fri, 26 Jan 2024 07:46:50 +0000 (UTC) Received: from localhost (91-158-86-216.elisa-laajakaista.fi [91.158.86.216]) by mail5.25mail.st (Postfix) with ESMTPSA id B0F1D603CF; Fri, 26 Jan 2024 07:45:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=atomide.com; s=25mailst; t=1706255202; bh=8um7kgRcb4+h5B+usK409ZVcM+9iTowtfffiEtyuFbU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JtJ7/piHUW7w/OVJCn29e2d2rEtLeVaOlov0zjBd4GqjORjulnAzkfm81/oQzmZk1 j6xBHePTSisRqweNOX99GF13HoBrDKZt3M3FEm+pqWIYwc79de+//TyrHnJ9U9EOqe tg4spfaNgHPO2SrEKND9EDfqrJeRITH4r90Dsd0YaLFoWXNsu44vFqxtM6bmDCF8xZ q8AbETzoLNZBW4g0gaa1xpveZk8WqCVR32N7uAqUyzV/DHuDLLdflpLjkse2IS/IKh kf7sQAEwt18oj3FLSAOArYc8w/JeDK204z24tczY7J+Y3Xxk3bJIUv198MVWlnb8bt c0jmXOYqHSWqw== Date: Fri, 26 Jan 2024 09:45:43 +0200 From: Tony Lindgren To: Andrew Davis Subject: Re: [PATCH 08/11] ARM: dts: DRA7xx: Add device tree entry for SGX GPU Message-ID: <20240126074543.GS5185@atomide.com> References: <20240109171950.31010-1-afd@ti.com> <20240109171950.31010-9-afd@ti.com> <20240110082924.GA5185@atomide.com> <55efd488-c6a0-4dca-baea-1fa93d13dd17@ti.com> <20240118085551.GQ5185@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240118085551.GQ5185@atomide.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Vignesh Raghavendra , "H . Nikolaus Schaller" , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, Paul Cercueil , Krzysztof Kozlowski , Ivaylo Dimitrov , Samuel Holland , Jernej Skrabec , Chen-Yu Tsai , linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, Conor Dooley , =?utf-8?Q?Beno=C3=AEt?= Cousson , Maxime Ripard , Matt Coster , Rob Herring , linux-omap@vger.kernel.org, Adam Ford , linux-arm-kernel@lists.infradead.org, Tero Kristo , linux-kernel@vger.kernel.org, Thomas Zimmermann Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" * Tony Lindgren [240118 08:57]: > * Andrew Davis [240117 15:52]: > > On 1/10/24 2:29 AM, Tony Lindgren wrote: > > > * Andrew Davis [240109 17:20]: > > > > --- a/arch/arm/boot/dts/ti/omap/dra7.dtsi > > > > +++ b/arch/arm/boot/dts/ti/omap/dra7.dtsi > > > > @@ -850,12 +850,19 @@ target-module@56000000 { > > > > ; > > > > ti,sysc-sidle = , > > > > , > > > > - ; > > > > + , > > > > + ; > > > > > > You probably checked this already.. But just in case, can you please > > > confirm this is intentional. The documentation lists the smart wakeup > > > capability bit as reserved for dra7, maybe the documentation is wrong. > > > > > > > It was an intentional change, although I'm not sure it is correct :) > > > > This is how we had it in our "evil vendor tree" for years (back when it > > was hwmod based), so when converting these nodes to use "ti,sysc" I noticed > > this bit was set, but as you point out the documentation disagrees. > > > > I'd rather go with what has worked before, but it doesn't seem to > > break anything either way, so we could also break this change out into > > its own patch if you would prefer. > > I agree it's best to stick what is known to work. How about let's add > the related information to the patch description? I'll update the commit message for it and apply these, no need to repost. Regards, Tony