* [PATCH] drm/xe: Declare __xe_lrc_*_ggtt_addr with __maybe__unused
@ 2024-02-04 6:23 Dawei Li
2024-03-05 1:50 ` Dawei Li
0 siblings, 1 reply; 3+ messages in thread
From: Dawei Li @ 2024-02-04 6:23 UTC (permalink / raw)
To: lucas.demarchi, ogabbay, thomas.hellstrom
Cc: maarten.lankhorst, mripard, tzimmermann, airlied, daniel,
intel-xe, dri-devel, linux-kernel, Dawei Li, kernel test robot
Kernel test robot reports building error:
drivers/gpu/drm/xe/xe_lrc.c:544:1: error: unused function
'__xe_lrc_regs_ggtt_addr' [-Werror,-Wunused-function]
544 | DECL_MAP_ADDR_HELPERS(regs)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/xe/xe_lrc.c:536:19: note: expanded from macro
'DECL_MAP_ADDR_HELPERS'
536 | static inline u32 __xe_lrc_##elem##_ggtt_addr(struct xe_lrc *lrc) \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
<scratch space>:54:1: note: expanded from here
54 | __xe_lrc_regs_ggtt_addr
| ^~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Declare __xe_lrc_*_ggtt_addr with __maybe_unused to address it.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202402010928.g3j2aSBL-lkp@intel.com/
Signed-off-by: Dawei Li <dawei.li@shingroup.cn>
---
drivers/gpu/drm/xe/xe_lrc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_lrc.c b/drivers/gpu/drm/xe/xe_lrc.c
index 0ec5ad2539f1..f70e60a2f8a3 100644
--- a/drivers/gpu/drm/xe/xe_lrc.c
+++ b/drivers/gpu/drm/xe/xe_lrc.c
@@ -614,7 +614,7 @@ static inline struct iosys_map __xe_lrc_##elem##_map(struct xe_lrc *lrc) \
iosys_map_incr(&map, __xe_lrc_##elem##_offset(lrc)); \
return map; \
} \
-static inline u32 __xe_lrc_##elem##_ggtt_addr(struct xe_lrc *lrc) \
+static inline u32 __maybe_unused __xe_lrc_##elem##_ggtt_addr(struct xe_lrc *lrc) \
{ \
return xe_bo_ggtt_addr(lrc->bo) + __xe_lrc_##elem##_offset(lrc); \
} \
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/xe: Declare __xe_lrc_*_ggtt_addr with __maybe__unused
2024-02-04 6:23 [PATCH] drm/xe: Declare __xe_lrc_*_ggtt_addr with __maybe__unused Dawei Li
@ 2024-03-05 1:50 ` Dawei Li
2024-03-07 15:52 ` Lucas De Marchi
0 siblings, 1 reply; 3+ messages in thread
From: Dawei Li @ 2024-03-05 1:50 UTC (permalink / raw)
To: lucas.demarchi, ogabbay, thomas.hellstrom
Cc: maarten.lankhorst, mripard, tzimmermann, airlied, daniel,
intel-xe, dri-devel, linux-kernel, kernel test robot
Hi,
On Sun, Feb 04, 2024 at 02:23:24PM +0800, Dawei Li wrote:
> Kernel test robot reports building error:
>
> drivers/gpu/drm/xe/xe_lrc.c:544:1: error: unused function
> '__xe_lrc_regs_ggtt_addr' [-Werror,-Wunused-function]
> 544 | DECL_MAP_ADDR_HELPERS(regs)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> drivers/gpu/drm/xe/xe_lrc.c:536:19: note: expanded from macro
> 'DECL_MAP_ADDR_HELPERS'
> 536 | static inline u32 __xe_lrc_##elem##_ggtt_addr(struct xe_lrc *lrc) \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> <scratch space>:54:1: note: expanded from here
> 54 | __xe_lrc_regs_ggtt_addr
> | ^~~~~~~~~~~~~~~~~~~~~~~
>
> 1 error generated.
>
> Declare __xe_lrc_*_ggtt_addr with __maybe_unused to address it.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202402010928.g3j2aSBL-lkp@intel.com/
> Signed-off-by: Dawei Li <dawei.li@shingroup.cn>
> ---
> drivers/gpu/drm/xe/xe_lrc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Just a gentle ping.
Thanks,
Dawei
>
> diff --git a/drivers/gpu/drm/xe/xe_lrc.c b/drivers/gpu/drm/xe/xe_lrc.c
> index 0ec5ad2539f1..f70e60a2f8a3 100644
> --- a/drivers/gpu/drm/xe/xe_lrc.c
> +++ b/drivers/gpu/drm/xe/xe_lrc.c
> @@ -614,7 +614,7 @@ static inline struct iosys_map __xe_lrc_##elem##_map(struct xe_lrc *lrc) \
> iosys_map_incr(&map, __xe_lrc_##elem##_offset(lrc)); \
> return map; \
> } \
> -static inline u32 __xe_lrc_##elem##_ggtt_addr(struct xe_lrc *lrc) \
> +static inline u32 __maybe_unused __xe_lrc_##elem##_ggtt_addr(struct xe_lrc *lrc) \
> { \
> return xe_bo_ggtt_addr(lrc->bo) + __xe_lrc_##elem##_offset(lrc); \
> } \
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/xe: Declare __xe_lrc_*_ggtt_addr with __maybe__unused
2024-03-05 1:50 ` Dawei Li
@ 2024-03-07 15:52 ` Lucas De Marchi
0 siblings, 0 replies; 3+ messages in thread
From: Lucas De Marchi @ 2024-03-07 15:52 UTC (permalink / raw)
To: Dawei Li
Cc: ogabbay, thomas.hellstrom, maarten.lankhorst, mripard,
tzimmermann, airlied, daniel, intel-xe, dri-devel, linux-kernel,
kernel test robot
On Tue, Mar 05, 2024 at 09:50:23AM +0800, Dawei Li wrote:
>Hi,
>
>On Sun, Feb 04, 2024 at 02:23:24PM +0800, Dawei Li wrote:
>> Kernel test robot reports building error:
>>
>> drivers/gpu/drm/xe/xe_lrc.c:544:1: error: unused function
>> '__xe_lrc_regs_ggtt_addr' [-Werror,-Wunused-function]
>> 544 | DECL_MAP_ADDR_HELPERS(regs)
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> drivers/gpu/drm/xe/xe_lrc.c:536:19: note: expanded from macro
>> 'DECL_MAP_ADDR_HELPERS'
>> 536 | static inline u32 __xe_lrc_##elem##_ggtt_addr(struct xe_lrc *lrc) \
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> <scratch space>:54:1: note: expanded from here
>> 54 | __xe_lrc_regs_ggtt_addr
>> | ^~~~~~~~~~~~~~~~~~~~~~~
>>
>> 1 error generated.
>>
>> Declare __xe_lrc_*_ggtt_addr with __maybe_unused to address it.
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202402010928.g3j2aSBL-lkp@intel.com/
>> Signed-off-by: Dawei Li <dawei.li@shingroup.cn>
>> ---
>> drivers/gpu/drm/xe/xe_lrc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>Just a gentle ping.
I tweaked the commit message a little bit and applied to drm-xe-next.
Thanks.
Lucas De Marchi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-07 15:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-04 6:23 [PATCH] drm/xe: Declare __xe_lrc_*_ggtt_addr with __maybe__unused Dawei Li
2024-03-05 1:50 ` Dawei Li
2024-03-07 15:52 ` Lucas De Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).