From: Tony Lindgren <tony@atomide.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Javier Martinez Canillas <javierm@redhat.com>,
Sam Ravnborg <sam@ravnborg.org>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/omapdrm: Fix console with deferred ops
Date: Sun, 25 Feb 2024 08:44:04 +0200 [thread overview]
Message-ID: <20240225064404.GS5299@atomide.com> (raw)
In-Reply-To: <2e37574b-dede-4bd6-8a71-32ab354f7510@suse.de>
* Thomas Zimmermann <tzimmermann@suse.de> [240220 10:42]:
> The changes below look good. You can test by instrumenting
> drm_fb_helper_deferred_io() with printk(). For testing, you can reduce the
> write-back frequency by setting helper->fbdefio.delay to a higher value. If
> you set it to HZ, it should only do a write-back once per second. Then do an
> mmap() from userspace and copy data into the memory region. It should print
> something from drm_fb_helper_deferred_io(). Best regards Thomas
OK thanks I tested with fbtest.c I found [0] with some trace_printk
added and it works nicely :) Will post v2 set of patches.
Regards,
Tony
[0] https://gist.github.com/rafalrusin/1482697
next prev parent reply other threads:[~2024-02-25 6:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 14:19 [PATCH 1/2] drm/omapdrm: Fix console by implementing fb_dirty Tony Lindgren
2024-02-19 14:19 ` [PATCH 2/2] drm/omapdrm: Fix console with deferred ops Tony Lindgren
2024-02-19 16:43 ` Thomas Zimmermann
2024-02-20 8:56 ` Tony Lindgren
2024-02-20 9:32 ` Thomas Zimmermann
2024-02-20 10:16 ` Tony Lindgren
2024-02-20 10:42 ` Thomas Zimmermann
2024-02-25 6:44 ` Tony Lindgren [this message]
2024-02-19 16:31 ` [PATCH 1/2] drm/omapdrm: Fix console by implementing fb_dirty Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240225064404.GS5299@atomide.com \
--to=tony@atomide.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=sam@ravnborg.org \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox