From: Thomas Zimmermann <tzimmermann@suse.de>
To: javierm@redhat.com, jani.nikula@linux.intel.com,
airlied@redhat.com, sean@poorly.run
Cc: dri-devel@lists.freedesktop.org, Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 1/7] drm/edid: Implement drm_probe_ddc() with drm_edid_probe_custom()
Date: Thu, 4 Apr 2024 17:03:18 +0200 [thread overview]
Message-ID: <20240404150857.5520-2-tzimmermann@suse.de> (raw)
In-Reply-To: <20240404150857.5520-1-tzimmermann@suse.de>
Move the logic from drm_probe_ddc() into drm_edid_probe_custom(),
which receives the EDID read function as argument. Allows drivers
without DDC to implement similar functionality without duplicating
the code.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/drm_edid.c | 22 +++++++++++++++++++---
include/drm/drm_edid.h | 3 +++
2 files changed, 22 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index ea77577a37864..a3e9333f9177a 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -2608,6 +2608,24 @@ void drm_edid_free(const struct drm_edid *drm_edid)
}
EXPORT_SYMBOL(drm_edid_free);
+/**
+ * drm_edid_probe_custom() - probe DDC presence
+ * @read_block: EDID block read function
+ * @context: Private data passed to the block read function
+ *
+ * Probes for EDID data. Only reads enough data to detect the presence
+ * of the EDID channel.
+ *
+ * Return: True on success, false on failure.
+ */
+bool drm_edid_probe_custom(read_block_fn read_block, void *context)
+{
+ unsigned char out;
+
+ return (read_block(context, &out, 0, 1) == 0);
+}
+EXPORT_SYMBOL(drm_edid_probe_custom);
+
/**
* drm_probe_ddc() - probe DDC presence
* @adapter: I2C adapter to probe
@@ -2617,9 +2635,7 @@ EXPORT_SYMBOL(drm_edid_free);
bool
drm_probe_ddc(struct i2c_adapter *adapter)
{
- unsigned char out;
-
- return (drm_do_probe_ddc_edid(adapter, &out, 0, 1) == 0);
+ return drm_edid_probe_custom(drm_do_probe_ddc_edid, adapter);
}
EXPORT_SYMBOL(drm_probe_ddc);
diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h
index 6f65bbf655a1f..4d1797ade5f1d 100644
--- a/include/drm/drm_edid.h
+++ b/include/drm/drm_edid.h
@@ -410,6 +410,9 @@ static inline void drm_edid_decode_panel_id(u32 panel_id, char vend[4], u16 *pro
drm_edid_decode_mfg_id(panel_id >> 16, vend);
}
+bool
+drm_edid_probe_custom(int (*read_block)(void *context, u8 *buf, unsigned int block, size_t len),
+ void *context);
bool drm_probe_ddc(struct i2c_adapter *adapter);
struct edid *drm_do_get_edid(struct drm_connector *connector,
int (*get_edid_block)(void *data, u8 *buf, unsigned int block,
--
2.44.0
next prev parent reply other threads:[~2024-04-04 15:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 15:03 [PATCH 0/7] drm/udl: Convert to struct drm_edid Thomas Zimmermann
2024-04-04 15:03 ` Thomas Zimmermann [this message]
2024-04-04 15:03 ` [PATCH 2/7] drm/edid: Test for EDID header in drm_edit_probe_custom() Thomas Zimmermann
2024-04-05 6:38 ` Jani Nikula
2024-04-05 7:06 ` Thomas Zimmermann
2024-04-04 15:03 ` [PATCH 3/7] drm/udl: Remove DRM_CONNECTOR_POLL_HPD Thomas Zimmermann
2024-04-04 15:03 ` [PATCH 4/7] drm/udl: Move drm_dev_{enter, exit}() into udl_get_edid_block() Thomas Zimmermann
2024-04-04 15:03 ` [PATCH 5/7] drm/udl: Clean up Makefile Thomas Zimmermann
2024-04-04 15:03 ` [PATCH 6/7] drm/udl: Untangle .get_modes() and .detect_ctx() Thomas Zimmermann
2024-04-05 7:09 ` Jani Nikula
2024-04-05 7:38 ` Thomas Zimmermann
2024-04-04 15:03 ` [PATCH 7/7] drm/udl: Remove struct udl_connector Thomas Zimmermann
2024-04-05 6:52 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240404150857.5520-2-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=javierm@redhat.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox