From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C19CBC27C79 for ; Wed, 19 Jun 2024 15:21:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 58D3510ED0C; Wed, 19 Jun 2024 15:21:10 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="E+SfKNmB"; dkim-atps=neutral Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3F2A010ED11 for ; Wed, 19 Jun 2024 15:21:09 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B0ABBCE1C5B; Wed, 19 Jun 2024 15:21:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C7CEC2BBFC; Wed, 19 Jun 2024 15:21:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718810465; bh=KhSfJ4C9g703OX8e3GlopxaArmHVXCI9LGJLDMc19B4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=E+SfKNmBu9nRoqGbUEf6dgIZyKMfBu//1hY/rxaUmxvRJ4IyHJkGKtOAk+3P540rs 8UZWiYT1W8n527IPRo44/wMcgdHoueDlWOE8ZC+v1haXC2YHtdRYBi2ob7xHOhwrPv hv/MarYsZVzzsAtLruZZXeeRofecye4DIlYB7t9jlKbynl9Z4KKxxs755w91Ndr2DP NC7uGz+khxLPRa6hqN8D23ISJNEZbHYNIP/wv1yl73rWmYttZajya8qqz9mWyYLyOJ aym/OlPx/r2ORCx//hxgw8dhYjGEPp1MY9vAdBtJ3p5GaOANTsvj1KCceeB894jxvz 4VwS1vCKGuOVQ== Date: Wed, 19 Jun 2024 08:21:04 -0700 From: Jakub Kicinski To: Omer Shpigelman Cc: Andrew Lunn , "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "netdev@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "ogabbay@kernel.org" , Zvika Yehudai Subject: Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver Message-ID: <20240619082104.2dcdcd86@kernel.org> In-Reply-To: <45e35940-c8fc-4f6c-8429-e6681a48b889@habana.ai> References: <20240613082208.1439968-1-oshpigelman@habana.ai> <20240613082208.1439968-10-oshpigelman@habana.ai> <10902044-fb02-4328-bf88-0b386ee51c78@lunn.ch> <621d4891-36d7-48c6-bdd8-2f3ca06a23f6@lunn.ch> <45e35940-c8fc-4f6c-8429-e6681a48b889@habana.ai> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 19 Jun 2024 07:16:20 +0000 Omer Shpigelman wrote: > >> Are you referring to get_module_eeprom_by_page()? if so, then it is not > >> supported by our FW, we read the entire data on device load. > >> However, I can hide that behind the new API and return only the > >> requested page if that's the intention. > > > > Well, if your firmware is so limited, then you might as well stick to > > the old API, and let the core do the conversion to the legacy > > code. But i'm surprised you don't allow access to the temperature > > sensors, received signal strength, voltages etc, which could be > > exported via HWMON. > > I'll stick to the old API. > Regaring the sensors, our compute driver (under accel/habanalabs) exports > them via HWMON. You support 400G, you really need to give the user the ability to access higher pages.