From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9A38C27C79 for ; Thu, 20 Jun 2024 13:51:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0103010EA0A; Thu, 20 Jun 2024 13:51:39 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="kCq4pkoJ"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 969C710EA0A for ; Thu, 20 Jun 2024 13:51:37 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id DE3D562184; Thu, 20 Jun 2024 13:51:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D39EC2BD10; Thu, 20 Jun 2024 13:51:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718891496; bh=NoN0yBxHD8GgnNnA8qv/Z0+nJZMr5eqvtKZvmOt/ABI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kCq4pkoJZO69wd4/U392ee7h74fLDIx6Ix0wMuYmhNF3a9+w6iKiYwEVm8xZkP1CN R2rgkhL4KFMGTEaqe51/iokDg91nv2rWZZGVRVPPeAf0SU9AJCLyHW+Kucasqp+UZt dLMdpFWewiPgWYEsp71JXGk7fP6uNIMyD4zvDLIM4JW6AVUMir2T3Or8fJmsKpiIl/ tHWk/k/wXILWTvP0WXK/gVawf2nbBO2GTgs+foEU09q7yzgs7diw+yu0PjC5Emk02Z MpTPeYLryy6izNy/qtERVsw7pZYGosTEc4oRrtI6zEXYXmaVIgE4MUTT4E3weTpl4K Ql+voDn8Q0UMg== Date: Thu, 20 Jun 2024 06:51:35 -0700 From: Jakub Kicinski To: Omer Shpigelman Cc: Andrew Lunn , "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "netdev@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "ogabbay@kernel.org" , Zvika Yehudai Subject: Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver Message-ID: <20240620065135.116d8edf@kernel.org> In-Reply-To: <5cb11774-a710-4edc-a55c-c529b0114ca4@habana.ai> References: <20240613082208.1439968-1-oshpigelman@habana.ai> <20240613082208.1439968-10-oshpigelman@habana.ai> <10902044-fb02-4328-bf88-0b386ee51c78@lunn.ch> <621d4891-36d7-48c6-bdd8-2f3ca06a23f6@lunn.ch> <45e35940-c8fc-4f6c-8429-e6681a48b889@habana.ai> <20240619082104.2dcdcd86@kernel.org> <5cb11774-a710-4edc-a55c-c529b0114ca4@habana.ai> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 20 Jun 2024 08:43:34 +0000 Omer Shpigelman wrote: > > You support 400G, you really need to give the user the ability > > to access higher pages. > > Actually the 200G and 400G modes in the ethtool code should be removed > from this patch set. They are not relevant for Gaudi2. I'll fix it in the > next version. How do your customers / users check SFP diagnostics?