From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0AFDC3064D for ; Tue, 25 Jun 2024 00:39:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BD8AC10E03F; Tue, 25 Jun 2024 00:39:10 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 7568810E03F for ; Tue, 25 Jun 2024 00:39:09 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 91F6D339; Mon, 24 Jun 2024 17:39:33 -0700 (PDT) Received: from minigeek.lan (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 272C03F6A8; Mon, 24 Jun 2024 17:39:06 -0700 (PDT) Date: Tue, 25 Jun 2024 01:37:25 +0100 From: Andre Przywara To: Ryan Walklin Cc: Maxime Ripard , Chen-Yu Tsai , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Jernej Skrabec , Samuel Holland , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Chris Morgan , John Watts , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 18/23] dt-bindings: allwinner: add H616 DE33 bus, clock and display bindings Message-ID: <20240625013725.4c5a3e7c@minigeek.lan> In-Reply-To: <20240620113150.83466-19-ryan@testtoast.com> References: <20240620113150.83466-1-ryan@testtoast.com> <20240620113150.83466-19-ryan@testtoast.com> Organization: Arm Ltd. X-Mailer: Claws Mail 4.2.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 20 Jun 2024 23:29:56 +1200 Ryan Walklin wrote: > The Allwinner H616 and variants have a new display engine revision > (DE33). > > Add display engine bus, clock and mixer bindings for the DE33. > > Signed-off-by: Ryan Walklin > --- > .../devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml | 7 ++++--- > .../bindings/clock/allwinner,sun8i-a83t-de2-clk.yaml | 1 + > .../bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml | 1 + > 3 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml b/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml > index 9845a187bdf65..631027375e33b 100644 > --- a/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml > +++ b/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml > @@ -23,9 +23,10 @@ properties: > compatible: > oneOf: > - const: allwinner,sun50i-a64-de2 > - - items: > - - const: allwinner,sun50i-h6-de3 > - - const: allwinner,sun50i-a64-de2 > + - enum: > + - allwinner,sun50i-h6-de3 > + - allwinner,sun50i-h616-de33 > + - const: allwinner,sun50i-a64-de2 That doesn't look right, that would allow: - h6-de - h616-de33 - a64-de2 which is not what we want, right? It's more: - h6-de, a64-de2 - h616-de, a64-de2 - a64-de2 I think allwinner,sun8i-a23-rsb.yaml uses the pattern you are after. Cheers, Andre > > reg: > maxItems: 1 > diff --git a/Documentation/devicetree/bindings/clock/allwinner,sun8i-a83t-de2-clk.yaml b/Documentation/devicetree/bindings/clock/allwinner,sun8i-a83t-de2-clk.yaml > index 70369bd633e40..7fcd55d468d49 100644 > --- a/Documentation/devicetree/bindings/clock/allwinner,sun8i-a83t-de2-clk.yaml > +++ b/Documentation/devicetree/bindings/clock/allwinner,sun8i-a83t-de2-clk.yaml > @@ -25,6 +25,7 @@ properties: > - const: allwinner,sun50i-a64-de2-clk > - const: allwinner,sun50i-h5-de2-clk > - const: allwinner,sun50i-h6-de3-clk > + - const: allwinner,sun50i-h616-de33-clk > - items: > - const: allwinner,sun8i-r40-de2-clk > - const: allwinner,sun8i-h3-de2-clk > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > index b75c1ec686ad2..c37eb8ae1b8ee 100644 > --- a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > +++ b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > @@ -24,6 +24,7 @@ properties: > - allwinner,sun50i-a64-de2-mixer-0 > - allwinner,sun50i-a64-de2-mixer-1 > - allwinner,sun50i-h6-de3-mixer-0 > + - allwinner,sun50i-h616-de33-mixer-0 > > reg: > maxItems: 1