From: Zack Rusin <zack.rusin@broadcom.com>
To: dri-devel@lists.freedesktop.org
Cc: Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
ian.forbes@broadcom.com, martin.krastev@broadcom.com,
maaz.mombasawala@broadcom.com,
Zack Rusin <zack.rusin@broadcom.com>
Subject: [PATCH v2 0/4] Fix various buffer mapping/import issues
Date: Fri, 28 Jun 2024 16:07:25 -0400 [thread overview]
Message-ID: <20240628200729.754669-1-zack.rusin@broadcom.com> (raw)
This small series fixes all known prime/dumb_buffer/buffer dirty
tracking issues. Fixing of dumb-buffers turned out to be a lot more
complex than I wanted it to be. There's not much that can be done
there because the driver has to support old userspace (our Xorg driver
expects those to not be gem buffers and special cases a bunch of
functionality) and new userspace (which expects the handles to be
gem buffers, at least to issue GEM_CLOSE).
The third patch deals with it by making the objects returned from
dumb-buffers both (raw buffers and surfaces referenced by the same
handle), which always works and doesn't require any changes in userspace.
This fixes the known KDE (KWin's) buffer rendering issues.
v2: Fix compute_crc in the second patch, as spotted by Martin
Zack Rusin (4):
drm/vmwgfx: Fix a deadlock in dma buf fence polling
drm/vmwgfx: Make sure the screen surface is ref counted
drm/vmwgfx: Fix handling of dumb buffers
drm/vmwgfx: Add basic support for external buffers
drivers/gpu/drm/vmwgfx/vmw_surface_cache.h | 10 +-
drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 127 +++---
drivers/gpu/drm/vmwgfx/vmwgfx_bo.h | 15 +-
drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 40 +-
drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 26 +-
drivers/gpu/drm/vmwgfx/vmwgfx_gem.c | 62 ++-
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 453 +++++++--------------
drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 17 +-
drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 14 +-
drivers/gpu/drm/vmwgfx/vmwgfx_prime.c | 32 +-
drivers/gpu/drm/vmwgfx/vmwgfx_resource.c | 27 +-
drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 33 +-
drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 145 +++----
drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 277 ++++++++++++-
drivers/gpu/drm/vmwgfx/vmwgfx_vkms.c | 40 +-
15 files changed, 788 insertions(+), 530 deletions(-)
--
2.40.1
next reply other threads:[~2024-06-28 20:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 20:07 Zack Rusin [this message]
2024-06-28 20:07 ` [PATCH v2 1/4] drm/vmwgfx: Fix a deadlock in dma buf fence polling Zack Rusin
2024-06-28 20:07 ` [PATCH v2 2/4] drm/vmwgfx: Make sure the screen surface is ref counted Zack Rusin
2024-06-28 20:07 ` [PATCH v2 3/4] drm/vmwgfx: Fix handling of dumb buffers Zack Rusin
2024-06-28 20:07 ` [PATCH v2 4/4] drm/vmwgfx: Add basic support for external buffers Zack Rusin
2024-07-01 12:23 ` [PATCH v2 0/4] Fix various buffer mapping/import issues Martin Krastev
2024-07-01 22:43 ` Maaz Mombasawala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240628200729.754669-1-zack.rusin@broadcom.com \
--to=zack.rusin@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ian.forbes@broadcom.com \
--cc=maaz.mombasawala@broadcom.com \
--cc=martin.krastev@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox