Re: [PATCH 2/2] drm/panthor: Fix sync-only jobs

[Boris Brezillon <boris.brezillon@collabora.com>]

On Fri, 28 Jun 2024 16:55:36 +0200
Boris Brezillon <boris.brezillon@collabora.com> wrote:

> -	/* Stream size is zero, nothing to do => return a NULL fence and let
> -	 * drm_sched signal the parent.
> +	/* Stream size is zero, nothing to do except making sure all previously
> +	 * submitted jobs are done before we signal the
> +	 * drm_sched_job::s_fence::finished fence.
>  	 */
> -	if (!job->call_info.size)
> -		return NULL;
> +	if (!job->call_info.size) {
> +		job->done_fence = dma_fence_get(queue->fence_ctx.last_fence);
> +		return job->done_fence;

Should be

		return dma_fence_get(job->done_fence);

to keep the get/put balanced.

> +	}
>