From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1EDAC2BD09 for ; Tue, 9 Jul 2024 10:12:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 105FF10E4E6; Tue, 9 Jul 2024 10:12:34 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="PkMI40gs"; dkim-atps=neutral Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9A32710E4E7 for ; Tue, 9 Jul 2024 10:12:31 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5A94FCE10C6; Tue, 9 Jul 2024 10:12:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1DD6C3277B; Tue, 9 Jul 2024 10:12:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1720519947; bh=QTVr9Ak9h9/KHymtrOw183jiVNTBqvgeZKw77gWCJ5o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PkMI40gsW6zHp2h+9tjVIOA0xbImY2jxyQ1RBtLfCelGp+X9ZtFmedSIOw6H3x9oj pIq4IMM5CGCULrV3JzmphPvyQ16LCYj4U2Tnbq8atH01in8LJunBfqo6icCtlU8JEc kh5uu1nw5N8Bqfpga21BWV30AIN1+IUCKmvAqh9c= Date: Tue, 9 Jul 2024 12:12:24 +0200 From: Greg KH To: Jocelyn Falempe Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , Bjorn Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Danilo Krummrich Subject: Re: [PATCH v2 4/4] drm/panic: Add a qr_code panic screen Message-ID: <2024070944-follow-crazy-ff95@gregkh> References: <20240709084458.158659-1-jfalempe@redhat.com> <20240709084458.158659-5-jfalempe@redhat.com> <2024070951-tall-effective-c916@gregkh> <2024070947-exorcism-purchase-2f28@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jul 09, 2024 at 12:04:02PM +0200, Jocelyn Falempe wrote: > > > On 09/07/2024 11:12, Greg KH wrote: > > On Tue, Jul 09, 2024 at 11:11:35AM +0200, Greg KH wrote: > > > On Tue, Jul 09, 2024 at 10:40:10AM +0200, Jocelyn Falempe wrote: > > > > +config DRM_PANIC_SCREEN_QR_CODE_URL > > > > + string "Base url of the QR code in the panic screen" > > > > + depends on DRM_PANIC_SCREEN_QR_CODE > > > > + help > > > > + This option sets the base url to report the kernel panic. If it's set > > > > + the qr code will contain the url and the kmsg compressed with zlib as > > > > + url parameter. If it's empty, the qr code will contain the kmsg as > > > > + uncompressed text only. > > > > > > meta-comment, should we by default do this on a kernel.org domain so > > > that no specific distro has to worry about hosing this type of web > > > service? > > > > Also, do you have the backend source for this to show how anyone can > > host it themselves as well? We can't add features to the kernel that no > > one but closed-source implementations will use for obvious reasons. > > I've made a proof of concept backend here: > https://github.com/kdj0c/panic_report/ > > And the javascript to decode the kmsg trace is here (under MIT licence): > https://github.com/kdj0c/panic_report/blob/main/docs/panic_report.js SPDX lines are your friend, you might want to look into that for this stuff :) > It uses the pako js library to uncompress the zlib data, which is also under > MIT/Zlib licence https://github.com/nodeca/pako/ Great, can you put that in the Kconfig help area for this option in your next version? > If kernel.org want to host a default service for that, that would be great. > It can be linked with https://bugzilla.kernel.org to easily create a bug, or > look for similar bugs. Someone should at least propose it if this is going to be an option that the kernel supports. thanks, greg k-h