From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A85B7C3DA41 for ; Wed, 10 Jul 2024 16:37:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 340DB10E2A2; Wed, 10 Jul 2024 16:37:10 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="aOB39CZJ"; dkim-atps=neutral Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3945E10E2A2 for ; Wed, 10 Jul 2024 16:37:09 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 4F2A8CE1710; Wed, 10 Jul 2024 16:36:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D988C4AF0E; Wed, 10 Jul 2024 16:36:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720629387; bh=VOEQami4KT93qBtaeJsQ3QrGdn1x7XmqJH9KjXDTUok=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aOB39CZJyMSyw1K+rruCMig4enLLpVwC4wmcFjrJNki6A1jlaMJwosJ9qi8gRob9s z7kFdpwuqr9jEMtf/y6F9JBirzQmzNumlVlD4b5l1/DcvZl1p0vOnft2M9nqMidkg2 fMeKFVzWzpdKvcOJw8T8tVAueyIBUoE5fy6eFWwP05DhpQeDO1LP4UgyB2r6dI3IcB VwAb4piQ8k8z2t0MaNbM+KdSE042QTqyYizf8pBU/ymZjtyw0F38O1P7ZzGOvlO5KG spFlwBsXz0iOlmIq8Tsu0Zw/Wqy210Von3cqCm6mraFQxJZhjqMZtEzBl7xdBYwb2m CVueEk61o919A== Date: Wed, 10 Jul 2024 09:36:24 -0700 From: Jakub Kicinski To: Mina Almasry Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org, bpf@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, Donald Hunter , "David S. Miller" , Eric Dumazet , Paolo Abeni , Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Andreas Larsson , Jesper Dangaard Brouer , Ilias Apalodimas , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Arnd Bergmann , Steffen Klassert , Herbert Xu , David Ahern , Willem de Bruijn , Shuah Khan , Sumit Semwal , "Christian =?UTF-8?B?S8O2bmln?=" , Bagas Sanjaya , Christoph Hellwig , Nikolay Aleksandrov , Taehee Yoo , Pavel Begunkov , David Wei , Jason Gunthorpe , Yunsheng Lin , Shailend Chand , Harshitha Ramamurthy , Shakeel Butt , Jeroen de Borst , Praveen Kaligineedi , Willem de Bruijn , Kaiyuan Zhang Subject: Re: [PATCH net-next v16 04/13] netdev: netdevice devmem allocator Message-ID: <20240710093624.26d22f02@kernel.org> In-Reply-To: <20240710001749.1388631-5-almasrymina@google.com> References: <20240710001749.1388631-1-almasrymina@google.com> <20240710001749.1388631-5-almasrymina@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 10 Jul 2024 00:17:37 +0000 Mina Almasry wrote: > + net_devmem_dmabuf_binding_get(binding); Why does every iov need to hold a ref? pp holds a ref and does its own accounting, so it won't disappear unless all the pages are returned.