From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9C09C5320E for ; Sun, 18 Aug 2024 17:47:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2D3D710E06E; Sun, 18 Aug 2024 17:47:24 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Wcnk5txf"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id A227A10E06E for ; Sun, 18 Aug 2024 17:47:23 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BC618541; Sun, 18 Aug 2024 19:46:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1724003182; bh=mSqn4Gb3nYN7bq1wMWuPkirN69s9DYJDsLSC1UO7f3A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Wcnk5txfIBp7NE0L7x5uh59YFtx7okufy3TuElfDwUIvPUbVh8D/PSkXvwAmYUcvu gCHU0D64VxcEWJPjgxr7rL2aQGzFdKv8shGKSYcZ4rn3vgYihKVtNkIiNidmUFcnmK DoYiCAgazwNMLAtmPeHmDAAQE47ZFr2jj9nAG8uU= Date: Sun, 18 Aug 2024 20:46:55 +0300 From: Laurent Pinchart To: Krzysztof Kozlowski Cc: Kieran Bingham , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] dt-bindings: display: renesas,du: add top-level constraints Message-ID: <20240818174655.GD29465@pendragon.ideasonboard.com> References: <20240818173003.122025-1-krzysztof.kozlowski@linaro.org> <20240818173003.122025-2-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240818173003.122025-2-krzysztof.kozlowski@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Krzysztof, Thank you for the patch. On Sun, Aug 18, 2024 at 07:30:03PM +0200, Krzysztof Kozlowski wrote: > Properties with variable number of items per each device are expected to > have widest constraints in top-level "properties:" block and further > customized (narrowed) in "if:then:". Add missing top-level constraints > for clocks, clock-names, interrupts, resets, reset-names, renesas,cmms > and renesas,vsps. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Laurent Pinchart > --- > .../bindings/display/renesas,du.yaml | 26 ++++++++++++++++--- > 1 file changed, 22 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/devicetree/bindings/display/renesas,du.yaml > index 147842b6465a..9a2d1c08cb1f 100644 > --- a/Documentation/devicetree/bindings/display/renesas,du.yaml > +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml > @@ -46,12 +46,26 @@ properties: > maxItems: 1 > > # See compatible-specific constraints below. > - clocks: true > - clock-names: true > + clocks: > + minItems: 1 > + maxItems: 8 > + > + clock-names: > + minItems: 1 > + maxItems: 8 > + > interrupts: > + minItems: 1 > + maxItems: 4 > description: Interrupt specifiers, one per DU channel > - resets: true > - reset-names: true > + > + resets: > + minItems: 1 > + maxItems: 2 > + > + reset-names: > + minItems: 1 > + maxItems: 2 > > power-domains: > maxItems: 1 > @@ -77,6 +91,8 @@ properties: > > renesas,cmms: > $ref: /schemas/types.yaml#/definitions/phandle-array > + minItems: 2 > + maxItems: 4 > items: > maxItems: 1 > description: > @@ -85,6 +101,8 @@ properties: > > renesas,vsps: > $ref: /schemas/types.yaml#/definitions/phandle-array > + minItems: 1 > + maxItems: 4 > items: > items: > - description: phandle to VSP instance that serves the DU channel -- Regards, Laurent Pinchart