dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Alex Deucher <alexdeucher@gmail.com>, Dave Airlie <airlied@redhat.com>
Cc: "Christian König" <christian.koenig@amd.com>,
	DRI <dri-devel@lists.freedesktop.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Linux Next Mailing List" <linux-next@vger.kernel.org>
Subject: linux-next: build failure after merge of the amdgpu tree
Date: Mon, 19 Aug 2024 11:56:54 +1000	[thread overview]
Message-ID: <20240819115654.77aeabcc@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 2148 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/amdgpu_job.c: In function 'amdgpu_job_timedout':
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c:90:33: error: too many arguments to function 'drm_sched_start'
   90 |                                 drm_sched_start(&ring->sched, true);
      |                                 ^~~~~~~~~~~~~~~
In file included from drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h:28,
                 from drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.h:29,
                 from drivers/gpu/drm/amd/amdgpu/amdgpu.h:43,
                 from drivers/gpu/drm/amd/amdgpu/amdgpu_job.c:30:
include/drm/gpu_scheduler.h:582:6: note: declared here
  582 | void drm_sched_start(struct drm_gpu_scheduler *sched);
      |      ^~~~~~~~~~~~~~~

Caused by commit

  15789fa0f0e2 ("drm/amdgpu: add per ring reset support (v5)")

interacting with commit

  83b501c1799a ("drm/scheduler: remove full_recover from drm_sched_start")

from the drm tree.

I have applied the following merge fix patch.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 19 Aug 2024 11:46:24 +1000
Subject: [PATCH] fixup for "drm/amdgpu: add per ring reset support (v5)"

interacting with "drm/scheduler: remove full_recover from drm_sched_start"
from the drm tree.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
index c6a1783fc9ef..597489dea114 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
@@ -87,7 +87,7 @@ static enum drm_gpu_sched_stat amdgpu_job_timedout(struct drm_sched_job *s_job)
 			atomic_inc(&ring->adev->gpu_reset_counter);
 			amdgpu_fence_driver_force_completion(ring);
 			if (amdgpu_ring_sched_ready(ring))
-				drm_sched_start(&ring->sched, true);
+				drm_sched_start(&ring->sched);
 			goto exit;
 		}
 	}
-- 
2.43.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2024-08-19  1:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-19  1:56 Stephen Rothwell [this message]
     [not found] <20231010124357.5251e100@canb.auug.org.au>
2023-10-19  1:06 ` linux-next: build failure after merge of the amdgpu tree Stephen Rothwell
2023-10-24  0:59   ` Stephen Rothwell
2023-10-24 12:57     ` Alex Deucher
2023-10-24 19:52       ` Alex Deucher
2023-10-24 21:47       ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2023-05-19  0:06 Stephen Rothwell
2023-05-19  3:10 ` James Zhu
2023-05-19 13:38 ` Alex Deucher
     [not found] <20220307111342.105ce204@canb.auug.org.au>
     [not found] ` <YiYC2fQgf7d/QPSM@sirena.org.uk>
2022-03-08 11:15   ` Noralf Trønnes
2021-12-03  1:11 Stephen Rothwell
2021-09-17  0:57 Stephen Rothwell
2021-07-28 12:34 Mark Brown
2021-02-05  2:12 Stephen Rothwell
     [not found] <20200612102552.2d573ebb@canb.auug.org.au>
2020-06-26  1:47 ` Stephen Rothwell
     [not found] <20190626212212.25b41df4@canb.auug.org.au>
2019-06-27  3:35 ` Stephen Rothwell
2019-06-27 14:18   ` Alex Deucher
2019-06-27 22:01     ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240819115654.77aeabcc@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=airlied@redhat.com \
    --cc=alexdeucher@gmail.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox