From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99B8BCA0EC3 for ; Thu, 29 Aug 2024 21:26:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2376D10E0BD; Thu, 29 Aug 2024 21:26:51 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="Q/aH4yCw"; dkim-atps=neutral Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by gabe.freedesktop.org (Postfix) with ESMTPS id 26AA310E0BD for ; Thu, 29 Aug 2024 21:26:49 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id B7A25A43B88; Thu, 29 Aug 2024 21:26:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE5BBC4CEC1; Thu, 29 Aug 2024 21:26:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724966807; bh=qv1w3i8ppp9WEatmXOTIDaygnDc4b+KopM2kue4iUXA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Q/aH4yCwlgAE0YdZkEXc5ZWzCRJpVizL7u3qOFqjdHTLBh/GACVu7V+LYtSu7k99i fuCsKpIG7Ycih3jx7Nea0jL7wfVPoPaH1K7VToVloVY9GnEbAh3blFw6mIfvwkfi8P v86W/H6gdGgrjLiTOcnC8zC7buNYkwMeca7w7pi0Q4Fy5cqWuRd9dFXOCmrZIEh0OG +egu64hiZCWHl0GbAoGuKWN2aH034agEq7Cezds5QwuoX+mPfEdjmTihMkJMsnin7J 6kRj6oJBykEyxE6SnnmmUTf7JH4YP5PCAIPbElrGwvuwvXryYVm9axq9Kg8g+IWpFZ IMeHpXeFot+4w== Date: Thu, 29 Aug 2024 14:26:43 -0700 From: Jakub Kicinski To: Mina Almasry Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arch@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Donald Hunter , Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Andreas Larsson , Jesper Dangaard Brouer , Ilias Apalodimas , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Arnd Bergmann , Steffen Klassert , Herbert Xu , David Ahern , Willem de Bruijn , "=?UTF-8?B?QmrDtnJuIFTDtnBl?= =?UTF-8?B?bA==?=" , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , Shuah Khan , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Sumit Semwal , "Christian =?UTF-8?B?S8O2bmln?=" , Pavel Begunkov , David Wei , Jason Gunthorpe , Yunsheng Lin , Shailend Chand , Harshitha Ramamurthy , Shakeel Butt , Jeroen de Borst , Praveen Kaligineedi , Bagas Sanjaya , Christoph Hellwig , Nikolay Aleksandrov , Taehee Yoo Subject: Re: [PATCH net-next v23 13/13] netdev: add dmabuf introspection Message-ID: <20240829142643.4aa5c52a@kernel.org> In-Reply-To: <20240829060126.2792671-14-almasrymina@google.com> References: <20240829060126.2792671-1-almasrymina@google.com> <20240829060126.2792671-14-almasrymina@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 29 Aug 2024 06:01:26 +0000 Mina Almasry wrote: > + binding = (struct net_devmem_dmabuf_binding *) > + rxq->mp_params.mp_priv; > + if (binding) { > + if (nla_put_u32(rsp, NETDEV_A_QUEUE_DMABUF, > + binding->id)) > + goto nla_put_failure; > + } > + struct net_devmem_dmabuf_binding *binding = pool->mp_priv; > + if (binding && nla_put_u32(rsp, NETDEV_A_PAGE_POOL_DMABUF, binding->id)) > + goto err_cancel; nit: this is better than the put in queue_fill_one() no need to cast void pointer there, and you can use a single if (binding && nla_put_u32(rsp, NETDEV_A_QUEUE_DMABUF, binding->id))) goto nla_put_failure;