From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C620CA0EC0 for ; Thu, 29 Aug 2024 21:28:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1D6B610E0DD; Thu, 29 Aug 2024 21:28:45 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="Ax9B3K99"; dkim-atps=neutral Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by gabe.freedesktop.org (Postfix) with ESMTPS id D1B0F10E0DD for ; Thu, 29 Aug 2024 21:28:43 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id E20B3A434A6; Thu, 29 Aug 2024 21:28:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F341EC4CEC1; Thu, 29 Aug 2024 21:28:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724966922; bh=eLbNQ6G9fAtikDeusW+cHvDy3CVuzcI4mzdMls/Dda8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ax9B3K99aMwINgqedd1GcT2dh/xdXD8pelnJFa0YCRuR/soamnOCjmO8Q7rJ4Fv6Q sEwbQInsjU1BtifOjEMXuzvy8/mh2sgE4y7ixp5ihzT99ZxVNrOYbXHac0LE26BZqQ CDSAE8Ak/F9AIweL+4PLXkKI80OiLotLrQWXEdHBtv1WWoo5JDPV0nnC+U0g8E6eAE kUQy9LribXMePHEEkB3FlLKdE9p4QFhr5jM8nv80dQ9ZJW5lx2PuyftHJGMGvhq9G1 yl/Yax3vmf6U7MAaxruFfaqjoDdufjyTrqszjtXIbsHkWAx/FV87xBCq1ChdTckR3V fVNP4KW9ZS8+Q== Date: Thu, 29 Aug 2024 14:28:39 -0700 From: Jakub Kicinski To: Mina Almasry Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arch@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Donald Hunter , Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Andreas Larsson , Jesper Dangaard Brouer , Ilias Apalodimas , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Arnd Bergmann , Steffen Klassert , Herbert Xu , David Ahern , Willem de Bruijn , "=?UTF-8?B?QmrDtnJuIFTDtnBl?= =?UTF-8?B?bA==?=" , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , Shuah Khan , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Sumit Semwal , "Christian =?UTF-8?B?S8O2bmln?=" , Pavel Begunkov , David Wei , Jason Gunthorpe , Yunsheng Lin , Shailend Chand , Harshitha Ramamurthy , Shakeel Butt , Jeroen de Borst , Praveen Kaligineedi , Bagas Sanjaya , Christoph Hellwig , Nikolay Aleksandrov , Taehee Yoo , Willem de Bruijn , Kaiyuan Zhang Subject: Re: [PATCH net-next v23 06/13] memory-provider: dmabuf devmem memory provider Message-ID: <20240829142839.7f09715b@kernel.org> In-Reply-To: <20240829060126.2792671-7-almasrymina@google.com> References: <20240829060126.2792671-1-almasrymina@google.com> <20240829060126.2792671-7-almasrymina@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 29 Aug 2024 06:01:19 +0000 Mina Almasry wrote: > + if (WARN_ON_ONCE(atomic_long_read(netmem_get_pp_ref_count_ref(netmem)) != > + 1)) nit: temporary variable for this refcount, please