dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Yafang Shao <laoar.shao@gmail.com>
To: torvalds@linux-foundation.org, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org, x86@kernel.org,
	linux-snps-arc@lists.infradead.org,
	linux-wireless@vger.kernel.org, intel-gfx@lists.freedesktop.org,
	intel-xe@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, ocfs2-devel@lists.linux.dev,
	"Yafang Shao" <laoar.shao@gmail.com>,
	"Serge Hallyn" <serge@hallyn.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Darren Hart" <dvhart@infradead.org>,
	"Davidlohr Bueso" <dave@stgolabs.net>,
	"André Almeida" <andrealmeid@igalia.com>
Subject: [PATCH 2/7] kernel: Replace get_task_comm() with %pTN
Date: Fri, 13 Dec 2024 13:46:05 +0800	[thread overview]
Message-ID: <20241213054610.55843-3-laoar.shao@gmail.com> (raw)
In-Reply-To: <20241213054610.55843-1-laoar.shao@gmail.com>

Since task->comm is guaranteed to be NUL-terminated, we can print it
directly without the need to copye it into a separate buffer. This
simplifies the code and avoids unnecessary operations.

Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
Cc: Serge Hallyn <serge@hallyn.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Darren Hart <dvhart@infradead.org>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Cc: "André Almeida" <andrealmeid@igalia.com>
---
 kernel/capability.c     | 12 ++++--------
 kernel/futex/waitwake.c |  5 ++---
 2 files changed, 6 insertions(+), 11 deletions(-)

diff --git a/kernel/capability.c b/kernel/capability.c
index dac4df77e376..4512cd797f49 100644
--- a/kernel/capability.c
+++ b/kernel/capability.c
@@ -38,10 +38,8 @@ __setup("no_file_caps", file_caps_disable);
 
 static void warn_legacy_capability_use(void)
 {
-	char name[sizeof(current->comm)];
-
-	pr_info_once("warning: `%s' uses 32-bit capabilities (legacy support in use)\n",
-		     get_task_comm(name, current));
+	pr_info_once("warning: `%pTN' uses 32-bit capabilities (legacy support in use)\n",
+		     current);
 }
 
 /*
@@ -62,10 +60,8 @@ static void warn_legacy_capability_use(void)
 
 static void warn_deprecated_v2(void)
 {
-	char name[sizeof(current->comm)];
-
-	pr_info_once("warning: `%s' uses deprecated v2 capabilities in a way that may be insecure\n",
-		     get_task_comm(name, current));
+	pr_info_once("warning: `%pTN' uses deprecated v2 capabilities in a way that may be insecure\n",
+		     current);
 }
 
 /*
diff --git a/kernel/futex/waitwake.c b/kernel/futex/waitwake.c
index 3a10375d9521..df8f8c85d776 100644
--- a/kernel/futex/waitwake.c
+++ b/kernel/futex/waitwake.c
@@ -210,13 +210,12 @@ static int futex_atomic_op_inuser(unsigned int encoded_op, u32 __user *uaddr)
 
 	if (encoded_op & (FUTEX_OP_OPARG_SHIFT << 28)) {
 		if (oparg < 0 || oparg > 31) {
-			char comm[sizeof(current->comm)];
 			/*
 			 * kill this print and return -EINVAL when userspace
 			 * is sane again
 			 */
-			pr_info_ratelimited("futex_wake_op: %s tries to shift op by %d; fix this program\n",
-					get_task_comm(comm, current), oparg);
+			pr_info_ratelimited("futex_wake_op: %pTN tries to shift op by %d; fix this program\n",
+					    current, oparg);
 			oparg &= 31;
 		}
 		oparg = 1 << oparg;
-- 
2.43.5


  parent reply	other threads:[~2024-12-13  5:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-13  5:46 [PATCH 0/7] vsprintf: Add %pTN to print Task Name Yafang Shao
2024-12-13  5:46 ` [PATCH 1/7] vsprintf: Add %pTN to print task name Yafang Shao
2024-12-13  8:05   ` Petr Mladek
2024-12-13  8:35     ` Kalle Valo
2024-12-13 13:27       ` Borislav Petkov
2024-12-13 17:11         ` Andy Shevchenko
2024-12-13  8:36     ` Yafang Shao
2024-12-13  5:46 ` Yafang Shao [this message]
2024-12-13  5:46 ` [PATCH 3/7] arch: Replace get_task_comm() with %pTN Yafang Shao
2024-12-13  5:46 ` [PATCH 4/7] net: " Yafang Shao
2024-12-13  5:46 ` [PATCH 5/7] security: " Yafang Shao
2024-12-16 23:02   ` Paul Moore
2024-12-17  0:41   ` Kees Cook
2024-12-17  1:08   ` Linus Torvalds
2024-12-13  5:46 ` [PATCH 6/7] drivers: Repace " Yafang Shao
2024-12-13  7:48   ` Jiri Slaby
2024-12-16 20:33   ` Lyude Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241213054610.55843-3-laoar.shao@gmail.com \
    --to=laoar.shao@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=andrealmeid@igalia.com \
    --cc=dave@stgolabs.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=dvhart@infradead.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nouveau@lists.freedesktop.org \
    --cc=ocfs2-devel@lists.linux.dev \
    --cc=peterz@infradead.org \
    --cc=serge@hallyn.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).