dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Wayne Lin <Wayne.Lin@amd.com>
To: <dri-devel@lists.freedesktop.org>
Cc: <lyude@redhat.com>, <imre.deak@intel.com>,
	<ville.syrjala@linux.intel.com>, <hwentlan@amd.com>,
	Wayne Lin <Wayne.Lin@amd.com>
Subject: [PATCH v4 0/2] Fix drm RAD print
Date: Mon, 13 Jan 2025 17:10:58 +0800	[thread overview]
Message-ID: <20250113091100.3314533-1-Wayne.Lin@amd.com> (raw)

This is v4 of [1], with the following changes:

- Fix warning caught by kernel test robot:
drivers/gpu/drm/display/drm_dp_mst_topology.c: In function 'drm_dp_mst_rad_to_str':
>> drivers/gpu/drm/display/drm_dp_mst_topology.c:201:81: warning: passing argument 2 of 'drm_dp_mst_get_ufp_num_at_lct_from_rad' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     201 |                 unpacked_rad[i] = drm_dp_mst_get_ufp_num_at_lct_from_rad(i + 1, rad);
         |                                                                                 ^~~
   drivers/gpu/drm/display/drm_dp_mst_topology.c:179:52: note: expected 'u8 *' {aka 'unsigned char *'} but argument is of type 'const u8 *' {aka 'const unsigned char *'}
     179 | drm_dp_mst_get_ufp_num_at_lct_from_rad(u8 lct, u8 *rad)
         |                                                ~~~~^~~


vim +201 drivers/gpu/drm/display/drm_dp_mst_topology.c

   193 
   194  static int
   195  drm_dp_mst_rad_to_str(const u8 rad[8], u8 lct, char *out, size_t len)
   196  {
   197          int i;
   198          u8 unpacked_rad[16] = {};
   199 
   200          for (i = 0; i < lct; i++)
 > 201                   unpacked_rad[i] = drm_dp_mst_get_ufp_num_at_lct_from_rad(i + 1, rad);
   202 
   203          /* TODO: Eventually add something to printk so we can format the rad
   204           * like this: 1.2.3
   205           */
   206          return snprintf(out, len, "%*phC", lct, unpacked_rad);
   207  }
   208 


Cc: Imre Deak <imre.deak@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Harry Wentland <hwentlan@amd.com>
Cc: Lyude Paul <lyude@redhat.com>

[1] https://patchwork.freedesktop.org/series/141832/

Wayne Lin (2):
  drm/dp_mst: Fix drm RAD print
  drm/dp_mst: Add helper to get port number at specific LCT from RAD

 drivers/gpu/drm/display/drm_dp_mst_topology.c | 31 +++++++++++++------
 include/drm/display/drm_dp_mst_helper.h       |  7 +++++
 2 files changed, 28 insertions(+), 10 deletions(-)

-- 
2.37.3


             reply	other threads:[~2025-01-13  9:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-13  9:10 Wayne Lin [this message]
2025-01-13  9:10 ` [PATCH v4 1/2] drm/dp_mst: Fix drm RAD print Wayne Lin
2025-01-13  9:11 ` [PATCH v4 2/2] drm/dp_mst: Add helper to get port number at specific LCT from RAD Wayne Lin
2025-01-13 21:41 ` [PATCH v4 0/2] Fix drm RAD print Lyude Paul
2025-01-14  1:59   ` Lin, Wayne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250113091100.3314533-1-Wayne.Lin@amd.com \
    --to=wayne.lin@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hwentlan@amd.com \
    --cc=imre.deak@intel.com \
    --cc=lyude@redhat.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox