From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB7F5C282DE for ; Mon, 10 Mar 2025 12:40:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1CB4C89B78; Mon, 10 Mar 2025 12:40:18 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="OU7eweTU"; dkim-atps=neutral Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4A42589B78 for ; Mon, 10 Mar 2025 12:40:17 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 4D2FBA45B73; Mon, 10 Mar 2025 12:34:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE40BC4CEF0; Mon, 10 Mar 2025 12:40:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741610416; bh=H8MkukXKrs1gXyaQdWlj/mYQZibbo5Fhpikh/80QqZk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OU7eweTUodKoVT9kzSHOX2+bCR2sRfjGewUj0AL42sokgzxf+zbLLoCvkUBRMkYHr YqnVHTLHzG8wBV9cQFVqvTFOfjOWP5vIlPsnRotGJQD5OIbBlvPQDqO7Xsuf/L0heg Frq89NR/lx7PZ39bM3gmfQgOjzXS3ZrX95CjIZn3m+32cf8DBqseFi667hvz6QONN3 hVb2aCfOLeMOHgO6/Jb+ffvfv0m/foHouvTQ44LvzUaBYY1TN0f8Fls4iOUWjThlqE BgK6bUDdsTF8X3lA7uovbQc3BT/2WTsUg33dxKagtAxdQOjCUFzc1bjTfJhfdQz230 mxjaGxJJgTEkw== Date: Mon, 10 Mar 2025 07:40:14 -0500 From: Rob Herring To: Ryan Walklin Cc: Maxime Ripard , Chen-Yu Tsai , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Jernej Skrabec , Samuel Holland , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Andre Przywara , Chris Morgan , Hironori KIKUCHI , Philippe Simons , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, Conor Dooley Subject: Re: [PATCH v8 05/11] dt-bindings: allwinner: add H616 DE33 bus binding Message-ID: <20250310124014.GA3866055-robh@kernel.org> References: <20250310092345.31708-1-ryan@testtoast.com> <20250310092345.31708-6-ryan@testtoast.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250310092345.31708-6-ryan@testtoast.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Mar 10, 2025 at 10:09:51PM +1300, Ryan Walklin wrote: > The Allwinner H616 and variants have a new display engine revision > (DE33). > > Add a display engine bus binding for the DE33 and increase reg maxItems > to 3 to accommodate additional register blocks. > > Signed-off-by: Ryan Walklin > Acked-by: Conor Dooley > Reviewed-by: Chen-Yu Tsai > > --- > Changelog v1..v2: > - Correct DE2 bus enum to reflect fallback devices accurately. > > Changelog v2..v3: > - Separate content into three patches for three separate subsystems > > Changelog v5..v6: > - Increase reg maxItems to 3. > --- > .../devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml b/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml > index 9845a187bdf6..317a27cf590b 100644 > --- a/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml > +++ b/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml > @@ -24,11 +24,14 @@ properties: > oneOf: > - const: allwinner,sun50i-a64-de2 > - items: > - - const: allwinner,sun50i-h6-de3 > + - enum: > + - allwinner,sun50i-h6-de3 > + - allwinner,sun50i-h616-de33 > - const: allwinner,sun50i-a64-de2 > > reg: > - maxItems: 1 > + minItems: 1 > + maxItems: 3 You have to define what each region is and the order. And there should be constraints such that the existing cases don't now allow 2-3 entries. > > allwinner,sram: > description: > -- > 2.48.1 >