From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: "Lyude Paul" <lyude@redhat.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Rob Clark" <robdclark@gmail.com>,
"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
"Sean Paul" <sean@poorly.run>,
"Marijn Suijten" <marijn.suijten@somainline.org>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Robert Foss" <rfoss@kernel.org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Xinliang Liu" <xinliang.liu@linaro.org>,
"Tian Tao" <tiantao6@hisilicon.com>,
"Xinwei Kong" <kong.kongxinwei@hisilicon.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Yongqin Liu" <yongqin.liu@linaro.org>,
"John Stultz" <jstultz@google.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Jani Nikula <jani.nikula@intel.com>
Subject: [RFC PATCH RESEND v4 0/6] drm/display: dp: add new DPCD access functions
Date: Mon, 24 Mar 2025 13:51:18 +0200 [thread overview]
Message-ID: <20250324-drm-rework-dpcd-access-v4-0-e80ff89593df@oss.qualcomm.com> (raw)
Existing DPCD access functions return an error code or the number of
bytes being read / write in case of partial access. However a lot of
drivers either (incorrectly) ignore partial access or mishandle error
codes. In other cases this results in a boilerplate code which compares
returned value with the size.
As suggested by Jani implement new set of DPCD access helpers, which
ignore partial access, always return 0 or an error code. Implement
new helpers using existing functions to ensure backwards compatibility
and to assess necessity to handle incomplete reads on a global scale.
Currently only one possible place has been identified, dp-aux-dev, which
needs to handle possible holes in DPCD.
This series targets only the DRM helpers code. If the approach is found
to be acceptable, each of the drivers should be converted on its own.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
Changes in v4:
- Actually dropped the dp-aux-dev patch (Lyude).
- Added two missing full stops in linuxdoc (Lyude).
- Link to v3: https://lore.kernel.org/r/20250307-drm-rework-dpcd-access-v3-0-9044a3a868ee@linaro.org
Changes in v3:
- Fixed cover letter (Jani)
- Added intel-gfx and intel-xe to get the series CI-tested (Jani)
- Link to v2: https://lore.kernel.org/r/20250301-drm-rework-dpcd-access-v2-0-4d92602fc7cd@linaro.org
Changes in v2:
- Reimplemented new helpers using old ones (Lyude)
- Reworked the drm_dp_dpcd_read_link_status() patch (Lyude)
- Dropped the dp-aux-dev patch (Jani)
- Link to v1: https://lore.kernel.org/r/20250117-drm-rework-dpcd-access-v1-0-7fc020e04dbc@linaro.org
---
Dmitry Baryshkov (6):
drm/display: dp: implement new access helpers
drm/display: dp: change drm_dp_dpcd_read_link_status() return value
drm/display: dp: use new DCPD access helpers
drm/display: dp-cec: use new DCPD access helpers
drm/display: dp-mst-topology: use new DCPD access helpers
drm/display: dp-tunnel: use new DCPD access helpers
drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 8 +-
.../gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 2 +-
drivers/gpu/drm/display/drm_dp_cec.c | 37 ++-
drivers/gpu/drm/display/drm_dp_helper.c | 307 +++++++++------------
drivers/gpu/drm/display/drm_dp_mst_topology.c | 105 ++++---
drivers/gpu/drm/display/drm_dp_tunnel.c | 20 +-
drivers/gpu/drm/hisilicon/hibmc/dp/dp_link.c | 4 +-
drivers/gpu/drm/msm/dp/dp_ctrl.c | 24 +-
drivers/gpu/drm/msm/dp/dp_link.c | 18 +-
drivers/gpu/drm/radeon/atombios_dp.c | 8 +-
include/drm/display/drm_dp_helper.h | 92 +++++-
11 files changed, 317 insertions(+), 308 deletions(-)
---
base-commit: b0894e40afe2bd05d1fda68cc364665ac2b00e09
change-id: 20241231-drm-rework-dpcd-access-b0fc2e47d613
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
next reply other threads:[~2025-03-24 11:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 11:51 Dmitry Baryshkov [this message]
2025-03-24 11:51 ` [PATCH RESEND RFC v4 1/6] drm/display: dp: implement new access helpers Dmitry Baryshkov
2025-03-24 11:51 ` [PATCH RESEND RFC v4 2/6] drm/display: dp: change drm_dp_dpcd_read_link_status() return value Dmitry Baryshkov
2025-03-24 11:51 ` [PATCH RESEND RFC v4 3/6] drm/display: dp: use new DCPD access helpers Dmitry Baryshkov
2025-04-09 18:27 ` Kees Bakker
2025-03-24 11:51 ` [PATCH RESEND RFC v4 4/6] drm/display: dp-cec: " Dmitry Baryshkov
2025-03-24 11:51 ` [PATCH RESEND RFC v4 5/6] drm/display: dp-mst-topology: " Dmitry Baryshkov
2025-03-24 11:51 ` [PATCH RESEND RFC v4 6/6] drm/display: dp-tunnel: " Dmitry Baryshkov
2025-03-24 19:34 ` [RFC PATCH RESEND v4 0/6] drm/display: dp: add new DPCD access functions Lyude Paul
2025-03-25 13:31 ` Dmitry Baryshkov
2025-03-25 14:21 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250324-drm-rework-dpcd-access-v4-0-e80ff89593df@oss.qualcomm.com \
--to=dmitry.baryshkov@oss.qualcomm.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrzej.hajda@intel.com \
--cc=christian.koenig@amd.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jani.nikula@linux.intel.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=jstultz@google.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_abhinavk@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=sumit.semwal@linaro.org \
--cc=tiantao6@hisilicon.com \
--cc=tzimmermann@suse.de \
--cc=xinliang.liu@linaro.org \
--cc=yongqin.liu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).