From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A5F6C28B20 for ; Fri, 28 Mar 2025 15:10:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7551910E201; Fri, 28 Mar 2025 15:10:06 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="f7qnPUyA"; dkim-atps=neutral Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by gabe.freedesktop.org (Postfix) with ESMTPS id 788FD10E201 for ; Fri, 28 Mar 2025 15:10:04 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id D0381A42B2F; Fri, 28 Mar 2025 15:04:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 053AEC4CEE5; Fri, 28 Mar 2025 15:10:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743174603; bh=8mVD449PawS/p5m/Co7ffo96wtsQqQSnrPundwS6NoI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f7qnPUyA7fNCJOX/b3W3QEGEVBZxw86ST+Rf3WT8ywwQiOA9WwaLvPlOJz1dIiYT4 WN8yfBOGiKSXetz+e0MCWbLf5GQGPuxGAYREMQaG37iRAf8S4Wg7i8wvLIvX2WKr+v e91YHfk6ViDsnqdTn7nagkrxGh8jZ6+WzSxlPw01XWxrdLeHOi4MAYhErYAOH6Jn4Z S6cAoXTdw9MyDFIazGhFh1JKDreJjMFKEGOo6OInVC9EPwa+/WgJHYqbniAYCyfHjO azNxz4vc/idtUeiGoxCY6bkomZ0Gy7XtfeItwDlOQKT+kwf/maxZawZ0Ey6pwqNJrO M0ZUtRLyPTqXA== Date: Fri, 28 Mar 2025 16:10:00 +0100 From: Maxime Ripard To: Vignesh Raman Cc: dri-devel@lists.freedesktop.org, daniels@collabora.com, helen.fornazier@gmail.com, airlied@gmail.com, simona.vetter@ffwll.ch, robdclark@gmail.com, guilherme.gallo@collabora.com, sergi.blanch.torne@collabora.com, valentine.burley@collabora.com, lumag@kernel.org, quic_abhinavk@quicinc.com, maarten.lankhorst@linux.intel.com, tzimmermann@suse.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 3/3] drm/ci: Add jobs to run KUnit tests Message-ID: <20250328-idealistic-invisible-unicorn-961d67@houat> References: <20250327160117.945165-1-vignesh.raman@collabora.com> <20250327160117.945165-4-vignesh.raman@collabora.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="75a2n7mh4apie7ji" Content-Disposition: inline In-Reply-To: <20250327160117.945165-4-vignesh.raman@collabora.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --75a2n7mh4apie7ji Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1 3/3] drm/ci: Add jobs to run KUnit tests MIME-Version: 1.0 On Thu, Mar 27, 2025 at 09:31:12PM +0530, Vignesh Raman wrote: > Add jobs to run KUnit tests using tools/testing/kunit/kunit.py tool. >=20 > Signed-off-by: Vignesh Raman > --- > drivers/gpu/drm/ci/gitlab-ci.yml | 1 + > drivers/gpu/drm/ci/kunit.sh | 34 ++++++++++++++++++++++++++++++++ > drivers/gpu/drm/ci/kunit.yml | 19 ++++++++++++++++++ > 3 files changed, 54 insertions(+) > create mode 100755 drivers/gpu/drm/ci/kunit.sh > create mode 100644 drivers/gpu/drm/ci/kunit.yml >=20 > diff --git a/drivers/gpu/drm/ci/gitlab-ci.yml b/drivers/gpu/drm/ci/gitlab= -ci.yml > index 9e61b49e9960..90ae57ca86a1 100644 > --- a/drivers/gpu/drm/ci/gitlab-ci.yml > +++ b/drivers/gpu/drm/ci/gitlab-ci.yml > @@ -109,6 +109,7 @@ include: > - drivers/gpu/drm/ci/build.yml > - drivers/gpu/drm/ci/test.yml > - drivers/gpu/drm/ci/check-devicetrees.yml > + - drivers/gpu/drm/ci/kunit.yml > - 'https://gitlab.freedesktop.org/gfx-ci/lab-status/-/raw/main/lab-sta= tus.yml' > =20 > =20 > diff --git a/drivers/gpu/drm/ci/kunit.sh b/drivers/gpu/drm/ci/kunit.sh > new file mode 100755 > index 000000000000..197b19d05fba > --- /dev/null > +++ b/drivers/gpu/drm/ci/kunit.sh > @@ -0,0 +1,34 @@ > +#!/bin/bash > +# SPDX-License-Identifier: MIT > + > +set -euxo pipefail > + > +case "${KERNEL_ARCH}" in > + "arm") > + QEMU_PKG=3D"qemu-system-arm" > + GCC_ARCH=3D"arm-linux-gnueabihf" > + ;; > + "arm64") > + QEMU_PKG=3D"qemu-system-aarch64" > + GCC_ARCH=3D"aarch64-linux-gnu" > + ;; > + "x86_64") > + QEMU_PKG=3D"qemu-system-x86" > + GCC_ARCH=3D"x86_64-linux-gnu" > + ;; > + *) > + echo "Unsupported architecture: ${KERNEL_ARCH}" > + exit 1 > + ;; > +esac > + > +export ARCH=3D"${KERNEL_ARCH}" > +export CROSS_COMPILE=3D"${GCC_ARCH}-" > + > +apt-get update -qq && apt-get install -y --no-install-recommends "${QEMU= _PKG}" Thanks for working on that. I'm a bit concerned about using making it entirely debian specific here. Between the call to apt, the gcc triplet and the qemu package name, this not really a script to run kunit tests, but to run them on Debian :) We should make it pretty explicit and / or just assume the runner has the right packages and call kunit directly. Maxime --75a2n7mh4apie7ji Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZ+a7yAAKCRDj7w1vZxhR xQvVAQD1lfS0Kb493V52mh+q8MQC1q6XrDmqPA2YMCaf+0CXYAEAs5AVppk0CIA3 T/QxymOrulLOT75Wz9HOu5L8QRI2NAg= =wBRy -----END PGP SIGNATURE----- --75a2n7mh4apie7ji--