From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4BC52C5AD49 for ; Thu, 29 May 2025 12:02:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B1BED10E088; Thu, 29 May 2025 12:02:24 +0000 (UTC) Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by gabe.freedesktop.org (Postfix) with ESMTPS id BEC5210E088 for ; Thu, 29 May 2025 12:02:23 +0000 (UTC) Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4b7PgR28wGz6L4tL; Thu, 29 May 2025 19:45:07 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id AF2D9140519; Thu, 29 May 2025 19:46:22 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 29 May 2025 13:46:21 +0200 Date: Thu, 29 May 2025 12:46:20 +0100 From: Jonathan Cameron To: Alistair Popple CC: , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 01/12] mm: Remove PFN_MAP, PFN_SG_CHAIN and PFN_SG_LAST Message-ID: <20250529124620.00006ac7@huawei.com> In-Reply-To: References: X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100004.china.huawei.com (7.191.162.219) To frapeml500008.china.huawei.com (7.182.85.71) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 29 May 2025 16:32:02 +1000 Alistair Popple wrote: > The PFN_MAP flag is no longer used for anything, so remove it. The > PFN_SG_CHAIN and PFN_SG_LAST flags never appear to have been used so > also remove them. Superficial thing but you seem to be be removing PFN_SPECIAL as well and this description and patche description don't mention that. > > Signed-off-by: Alistair Popple > Reviewed-by: Christoph Hellwig On superficial comment inline. > --- > include/linux/pfn_t.h | 31 +++---------------------------- > mm/memory.c | 2 -- > tools/testing/nvdimm/test/iomap.c | 4 ---- > 3 files changed, 3 insertions(+), 34 deletions(-) > > diff --git a/include/linux/pfn_t.h b/include/linux/pfn_t.h > index 2d91482..46afa12 100644 > --- a/include/linux/pfn_t.h > +++ b/include/linux/pfn_t.h > @@ -5,26 +5,13 @@ > diff --git a/tools/testing/nvdimm/test/iomap.c b/tools/testing/nvdimm/test/iomap.c > index e431372..ddceb04 100644 > --- a/tools/testing/nvdimm/test/iomap.c > +++ b/tools/testing/nvdimm/test/iomap.c > @@ -137,10 +137,6 @@ EXPORT_SYMBOL_GPL(__wrap_devm_memremap_pages); > > pfn_t __wrap_phys_to_pfn_t(phys_addr_t addr, unsigned long flags) > { > - struct nfit_test_resource *nfit_res = get_nfit_res(addr); > - > - if (nfit_res) > - flags &= ~PFN_MAP; > return phys_to_pfn_t(addr, flags); Maybe not the time to point it out, but what is going on with indent here? Looks like some spaces snuck in for that last line. > } > EXPORT_SYMBOL(__wrap_phys_to_pfn_t);